Skip to content

Commit 2a31adb

Browse files
committed
Revert "Try problematic acqfs"
This reverts commit 450116a.
1 parent 450116a commit 2a31adb

2 files changed

Lines changed: 0 additions & 16 deletions

File tree

baybe/acquisition/acqfs.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,6 @@ class qExpectedImprovement(AcquisitionFunction):
4242
_abbreviation: ClassVar[str] = "qEI"
4343

4444

45-
@define(frozen=True)
46-
class NoisyExpectedImprovement(AcquisitionFunction):
47-
"""Analytical noisy expected improvement."""
48-
49-
_abbreviation: ClassVar[str] = "NEI"
50-
51-
5245
@define(frozen=True)
5346
class qNoisyExpectedImprovement(AcquisitionFunction):
5447
"""Monte Carlo based noisy expected improvement."""
@@ -86,13 +79,6 @@ class ProbabilityOfImprovement(AcquisitionFunction):
8679
_abbreviation: ClassVar[str] = "PI"
8780

8881

89-
@define(frozen=True)
90-
class LogProbabilityOfImprovement(AcquisitionFunction):
91-
"""Analytical logarithmic probability of improvement."""
92-
93-
_abbreviation: ClassVar[str] = "LogPI"
94-
95-
9682
@define(frozen=True)
9783
class qProbabilityOfImprovement(AcquisitionFunction):
9884
"""Monte Carlo based probability of improvement."""

baybe/acquisition/base.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ def to_botorch(
5252

5353
if "best_f" in signature(acqf_cls).parameters:
5454
fields_dict.update({"best_f": best_f})
55-
if "X_observed" in signature(acqf_cls).parameters:
56-
fields_dict.update({"X_observed": to_tensor(train_x)})
5755

5856
botorch_acqf = acqf_cls(AdapterModel(surrogate), **fields_dict)
5957
else:

0 commit comments

Comments
 (0)