Skip to content

Commit 82fd16e

Browse files
committed
Improvements to the zxing-cpp Qt/QML wrapper
1 parent 80f8631 commit 82fd16e

5 files changed

Lines changed: 201 additions & 149 deletions

File tree

src/utils_camera.cpp

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ QCameraFormat UtilsCamera::selectCameraFormat(int idx)
5454
int optimalPixelFormat = QVideoFrameFormat::Format_Invalid;
5555

5656
// square formats
57-
for (const auto &format : formats)
57+
for (const auto &format : std::as_const(formats))
5858
{
5959
qWarning() << "QCameraFormat(" << idx << ") res: " << format.resolution() << " pix: " << format.pixelFormat();
6060

@@ -79,17 +79,31 @@ QCameraFormat UtilsCamera::selectCameraFormat(int idx)
7979
}
8080

8181
// non square formats
82-
for (const auto &format : formats)
82+
for (const auto &format : std::as_const(formats))
8383
{
8484
qWarning() << "QCameraFormat(" << idx << ") res: " << format.resolution() << " pix: " << format.pixelFormat();
8585

86+
if (format.resolution() == QSize(1280, 720) &&
87+
(!optimalPixelFormat || (optimalPixelFormat && format.pixelFormat() == optimalPixelFormat)))
88+
{
89+
qWarning() << "SELECTED FORMAT res: " << format.resolution() << " pix: " << format.pixelFormat();
90+
return format;
91+
}
92+
8693
if (format.resolution() == QSize(1440, 1080) &&
8794
(!optimalPixelFormat || (optimalPixelFormat && format.pixelFormat() == optimalPixelFormat)))
8895
{
8996
qWarning() << "SELECTED FORMAT res: " << format.resolution() << " pix: " << format.pixelFormat();
9097
return format;
9198
}
9299

100+
if (format.resolution() == QSize(1920, 1080) &&
101+
(!optimalPixelFormat || (optimalPixelFormat && format.pixelFormat() == optimalPixelFormat)))
102+
{
103+
qWarning() << "SELECTED FORMAT res: " << format.resolution() << " pix: " << format.pixelFormat();
104+
return format;
105+
}
106+
93107
if (format.resolution() == QSize(2560, 1440) &&
94108
(!optimalPixelFormat || (optimalPixelFormat && format.pixelFormat() == optimalPixelFormat)))
95109
{

0 commit comments

Comments
 (0)