test: use client_authentication_failed tracepoint

Author: zmstone

src/gen_rpc_client.erl

@@ -297,24 +297,14 @@ handle_continue({connect, Node, Port, Key}, #state{driver_mod = DriverMod, drive
                     {stop, {shutdown, Error}, State}
             end;
         {error, ReasonTuple} ->
-            case ReasonTuple of
-                {badrpc, invalid_cookie} ->
-                    ?tp(error, gen_rpc_client_authentication_bad_cookie, #{
-                        driver => Driver,
-                        node => Node,
-                        port => Port,
-                        key => Key,
-                        domain => ?D_CLIENT
-                    });
-                _ ->
-                    ok
-            end,
-            ?log(error, "client_authentication_failed",
-                 #{driver => Driver,
-                   node => Node,
-                   port => Port,
-                   key => Key,
-                   cause => ReasonTuple}),
+            ?tp(error, client_authentication_failed, #{
+                driver => Driver,
+                node => Node,
+                port => Port,
+                key => Key,
+                cause => ReasonTuple,
+                domain => ?D_CLIENT
+            }),
             {stop, {shutdown, ReasonTuple}, State};
         {unreachable, Reason} ->
             %% This should be badtcp but to conform with

test/auth_SUITE.erl

@@ -139,7 +139,7 @@ t_auth_server_fail(Config) ->
            )
        end,
        [ fun ?MODULE:prop_canary/1
-       , fun ?MODULE:prop_invalid_cookie_error_trace/1
+       , fun ?MODULE:prop_client_authentication_failed_trace/1
        ]).
 
 %% In this testcase we don't test auth, but the rest of the gen_rpc library.
@@ -293,8 +293,20 @@ canary() ->
 prop_canary(Trace) ->
     ?assertMatch([], ?of_kind(gen_rpc_canary, Trace)).
 
-prop_invalid_cookie_error_trace(Trace) ->
-    ?assertMatch([_ | _], ?of_kind(gen_rpc_client_authentication_bad_cookie, Trace)).
+prop_client_authentication_failed_trace(Trace) ->
+    Events = ?of_kind(client_authentication_failed, Trace),
+    ?assertMatch([_ | _], Events),
+    ?assert(
+        lists:any(
+            fun
+                (#{cause := {badrpc, invalid_cookie}}) ->
+                    true;
+                (_) ->
+                    false
+            end,
+            Events
+        )
+    ).
 
 prop_no_fallback(Trace) ->
     ?assertMatch([], ?of_kind([gen_rpc_insecure_fallback, gen_rpc_auth_cr_v1_fallback], Trace)).