Write a partial list when supported, otherwise the complete cached list

The Hvac and Setpoint write helpers sent a list containing only the
modified entry. Servers that interpret the payload as a full replacement
would then drop unrelated system functions, overruns or setpoints.

Send a proper partial write when the remote advertises WritePartial().
Otherwise copy the cached list, merge the modified entries and write the
complete list, matching the LoadControl/DeviceConfiguration behaviour.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: andig

features/client/hvac.go

@@ -5,6 +5,7 @@ import (
 	"github.com/enbility/eebus-go/features/internal"
 	spineapi "github.com/enbility/spine-go/api"
 	"github.com/enbility/spine-go/model"
+	"github.com/enbility/spine-go/util"
 )
 
 type Hvac struct {
@@ -89,11 +90,29 @@ func (h *Hvac) WriteHvacSystemFunctionListData(
 		return nil, api.ErrNotSupported
 	}
 
+	// use a partial write when the server supports it, otherwise merge the
+	// modified entries into the cached list and write the complete list, so
+	// unrelated system functions are not dropped by a full replacement
+	filters := []model.FilterType{*model.NewFilterTypePartial()}
+	if !operation.WritePartial() {
+		filters = nil
+		updateData := &model.HvacSystemFunctionListDataType{
+			HvacSystemFunctionData: data,
+		}
+		if mergedData, err := h.featureRemote.UpdateData(false, model.FunctionTypeHvacSystemFunctionListData, updateData, nil, nil); err == nil {
+			data = mergedData.([]model.HvacSystemFunctionDataType)
+		}
+	}
+
 	cmd := model.CmdType{
 		HvacSystemFunctionListData: &model.HvacSystemFunctionListDataType{
 			HvacSystemFunctionData: data,
 		},
 	}
+	if filters != nil {
+		cmd.Filter = filters
+		cmd.Function = util.Ptr(model.FunctionTypeHvacSystemFunctionListData)
+	}
 
 	return h.remoteDevice.Sender().Write(h.featureLocal.Address(), h.featureRemote.Address(), cmd)
 }

features/client/hvac_test.go

@@ -109,3 +109,32 @@ func (s *HvacSuite) Test_WriteHvacSystemFunctionListData() {
 	assert.Nil(s.T(), err)
 	assert.NotNil(s.T(), counter)
 }
+
+func (s *HvacSuite) Test_WriteHvacSystemFunctionListData_Partial() {
+	localEntity, remoteEntity := setupFeatures(
+		s.T(),
+		s,
+		[]featureFunctions{
+			{
+				featureType: model.FeatureTypeTypeHvac,
+				functions: []model.FunctionType{
+					model.FunctionTypeHvacSystemFunctionListData,
+				},
+				partial: true,
+			},
+		},
+	)
+
+	hvac, err := NewHvac(localEntity, remoteEntity)
+	assert.Nil(s.T(), err)
+
+	data := []model.HvacSystemFunctionDataType{
+		{
+			SystemFunctionId:       util.Ptr(model.HvacSystemFunctionIdType(1)),
+			CurrentOperationModeId: util.Ptr(model.HvacOperationModeIdType(2)),
+		},
+	}
+	counter, err := hvac.WriteHvacSystemFunctionListData(data)
+	assert.Nil(s.T(), err)
+	assert.NotNil(s.T(), counter)
+}

features/client/setpoint.go

@@ -5,6 +5,7 @@ import (
 	"github.com/enbility/eebus-go/features/internal"
 	spineapi "github.com/enbility/spine-go/api"
 	"github.com/enbility/spine-go/model"
+	"github.com/enbility/spine-go/util"
 )
 
 type Setpoint struct {
@@ -73,11 +74,29 @@ func (s *Setpoint) WriteSetpointListData(
 		return nil, api.ErrNotSupported
 	}
 
+	// use a partial write when the server supports it, otherwise merge the
+	// modified entries into the cached list and write the complete list, so
+	// unrelated setpoints are not dropped by a full replacement
+	filters := []model.FilterType{*model.NewFilterTypePartial()}
+	if !operation.WritePartial() {
+		filters = nil
+		updateData := &model.SetpointListDataType{
+			SetpointData: data,
+		}
+		if mergedData, err := s.featureRemote.UpdateData(false, model.FunctionTypeSetpointListData, updateData, nil, nil); err == nil {
+			data = mergedData.([]model.SetpointDataType)
+		}
+	}
+
 	cmd := model.CmdType{
 		SetpointListData: &model.SetpointListDataType{
 			SetpointData: data,
 		},
 	}
+	if filters != nil {
+		cmd.Filter = filters
+		cmd.Function = util.Ptr(model.FunctionTypeSetpointListData)
+	}
 
 	return s.remoteDevice.Sender().Write(s.featureLocal.Address(), s.featureRemote.Address(), cmd)
 }