Skip to content

Commit bd56405

Browse files
author
endolinbot
committed
design(captp): identifyError/traces facet consolidation at builder's discretion (#595)
Per kriskowal review 4616479253: the new identifyError diagnostics facet and the existing host traces facet are related; consolidation is left to the builder's discretion. Resolves Open Question 4 (and updates the section header now that all four questions are resolved).
1 parent e46b5b9 commit bd56405

1 file changed

Lines changed: 14 additions & 4 deletions

File tree

designs/captp-error-identification.md

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,13 @@ This replaces #58's more list-shaped `traces.lookup(errorId)` surface with an
201201
ocap-clean `identifyError(err)`: you must already hold the error object *and* the
202202
diagnostics facet to identify.
203203

204+
Per kriskowal's review of #595, the new `identifyError` diagnostics facet and the
205+
existing host `traces` facet are **related**, and **consolidating them is left to
206+
the builder's discretion**: the build may fold `identifyError` into the existing
207+
`traces` facet, or mint a distinct per-session diagnostics facet, whichever reads
208+
cleaner in the daemon at build time. Either way the identifier lives only in the
209+
side table and never on the error.
210+
204211
**OCapN/CapTP change:** define where the closely-held identification facet is
205212
minted (per-session bootstrap or an explicit grant) and that it reads only the
206213
session-scoped side table.
@@ -295,7 +302,7 @@ Called out in the same review, to be carried by the **build** PR, not here:
295302
grow builder directives + a reviewer that prevent inline typedefs recurring —
296303
a garden-infra follow-up, tracked separately.)
297304

298-
## Open Questions
305+
## Open Questions (all resolved by kriskowal's review of #595)
299306

300307
1. **Wire-format negotiation — RESOLVED (kriskowal, #595).** There are no existing
301308
deployments of any consequence, so mixed-version interop is not a constraint:
@@ -311,6 +318,9 @@ Called out in the same review, to be carried by the **build** PR, not here:
311318
design handed to @erights:
312319
[`unredacted-stack-sanctioned-ses-api.md`](./unredacted-stack-sanctioned-ses-api.md).
313320
Out of scope for this design.
314-
4. **Facet placement.** Where the closely-held `identifyError` facet is minted
315-
(per-session bootstrap vs. explicit grant) and its relationship to the existing
316-
host `traces` facet.
321+
4. **Facet placement — RESOLVED (kriskowal, #595).** The `identifyError` facet and
322+
the existing host `traces` facet are related; **consolidation is at the
323+
builder's discretion** (fold into `traces`, or mint a distinct diagnostics
324+
facet). See *`identifyError` is closely held* above. Where exactly the facet is
325+
minted (per-session bootstrap vs. explicit grant) follows from that build-time
326+
choice.

0 commit comments

Comments
 (0)