Skip to content

Commit cb597b2

Browse files
endolinbotendolinbot
authored andcommitted
test(compartment-mapper): drop issue citations from unused-assertions module
The _cycle-rename-unused-assertions.js module still had two references that the no-pull-citations gate catches: endojs/endo#59 in the module preamble and "issue #59 fix" in the body. Rewrite prose to stand on its own description (cyclic-star-export regression, deferring closure) without citing the bot-fork or upstream issue number. This continues the sweep begun in b7e77cf which swept the same references from the cycle-rename-tdz-matrix files.
1 parent 9fbaaf7 commit cb597b2

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

packages/compartment-mapper/test/_cycle-rename-unused-assertions.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
/**
22
* Shared assertion logic for the unused-live-binding shape of the cyclic
3-
* star-export with renaming reexport regression (endojs/endo#59). This is
4-
* the companion to the populated shape exercised by
5-
* `_cycle-rename-assertions.js`; the only difference is that the renamer's
6-
* `export var y` here has no initializer, so the live binding is declared
7-
* but never updated. Every projection of the cycle therefore reads
8-
* `undefined`. Both the Node.js parity test and the Compartment Mapper test
9-
* import from this module so the expected values live in exactly one place;
10-
* if both tests pass, parity with Node.js is verified by construction.
3+
* star-export with renaming reexport regression. This is the companion to
4+
* the populated shape exercised by `_cycle-rename-assertions.js`; the only
5+
* difference is that the renamer's `export var y` here has no initializer,
6+
* so the live binding is declared but never updated. Every projection of the
7+
* cycle therefore reads `undefined`. Both the Node.js parity test and the
8+
* Compartment Mapper test import from this module so the expected values
9+
* live in exactly one place; if both tests pass, parity with Node.js is
10+
* verified by construction.
1111
*
1212
* The fixture under fixtures-cycle-rename-unused/node_modules/app/ exercises
1313
* this arrangement:
@@ -22,9 +22,9 @@
2222
* export const namespace1 = { x: ns1.x, y: ns1.y };
2323
* export const namespace2 = { x: ns2.x, y: ns2.y };
2424
*
25-
* The deferring closure introduced by the issue #59 fix queues subscribers
26-
* until the upstream notifier resolves, then forwards them. With no
27-
* initializer the upstream's value never updates, so every read is
25+
* The deferring closure introduced by the cyclic-star-export fix queues
26+
* subscribers until the upstream notifier resolves, then forwards them.
27+
* With no initializer the upstream's value never updates, so every read is
2828
* `undefined`. Node.js exhibits the same shape, so the parity test pins
2929
* both layers to a single expected projection.
3030
*

0 commit comments

Comments
 (0)