Fix: [ENG-836] project_permissions JSON field name in API key creation (ENG-836)#1078
Closed
liranfarage89 wants to merge 2 commits into
Closed
Fix: [ENG-836] project_permissions JSON field name in API key creation (ENG-836)#1078liranfarage89 wants to merge 2 commits into
liranfarage89 wants to merge 2 commits into
Conversation
- Change JSON tag from 'projectsPermissions' to 'projectPermissions' in ApiKeyPermissions struct - Add comprehensive tests to verify correct JSON serialization - Fixes 403 errors when API keys have project_permissions configured - Resolves issue ENG-836 reported by Adaptavist and Allstate users The incorrect JSON field name prevented project permissions from being properly assigned to API keys, causing authorization failures.
liranfarage89
changed the title
- Revert JSON tag from 'projectPermissions' back to 'projectsPermissions' in ApiKeyPermissions struct - Update tests to verify 'projectsPermissions' field name - This reverts commit 8997832 The original field name 'projectsPermissions' was correct per API specification.
Contributor
Author
|
nvm it's irrelevant... resolved by @eranelbaz already #1077 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users reported that API keys created with blocks were not receiving the correct project access, resulting in 403 errors. This affected multiple customers including Adaptavist and Allstate.
Root Cause
The struct in was using an incorrect JSON field name:
This mismatch prevented project permissions from being properly assigned during API key creation.
Solution
Changes
Testing
Impact
This fix ensures that API keys with configurations receive the proper project assignments, resolving the 403 authorization errors reported by users.
Fixes: ENG-836