fix(chat): skip temperature sending when such feature is disabled (Issue #6449) (#6459)

Author: Alexander-Kezik

apps/chat/src/pages/api/chat.ts

@@ -23,10 +23,7 @@ import { ChatBody } from '@/src/types/chat';
 import { EntityType } from '@/src/types/common';
 
 import { DEFAULT_SYSTEM_PROMPT } from '@/src/constants/default-server-settings';
-import {
-  DEFAULT_TEMPERATURE,
-  FALLBACK_TEMPERATURE,
-} from '@/src/constants/default-ui-settings';
+import { DEFAULT_TEMPERATURE } from '@/src/constants/default-ui-settings';
 import { errorsMessages } from '@/src/constants/errors';
 
 import { authOptions } from './auth/[...nextauth]';
@@ -65,9 +62,8 @@ const handler = async (req: NextApiRequest, res: NextApiResponse) => {
     }
 
     let temperatureToUse = temperature;
-    if (!doesModelAllowTemperature(model)) {
-      temperatureToUse = FALLBACK_TEMPERATURE;
-    } else if (
+    if (
+      doesModelAllowTemperature(model) &&
       !temperatureToUse &&
       temperatureToUse !== 0 &&
       model.type !== EntityType.Application
@@ -111,7 +107,6 @@ const handler = async (req: NextApiRequest, res: NextApiResponse) => {
 
     const stream = await OpenAIStream({
       model,
-      temperature: temperatureToUse,
       messages: messagesToSend,
       userJWT: token?.token ?? '',
       chatReference: reference ?? id,
@@ -120,6 +115,7 @@ const handler = async (req: NextApiRequest, res: NextApiResponse) => {
         ? limits?.maxRequestTokens
         : undefined,
       configurationSchemaValue: configurationValue,
+      ...(temperatureToUse !== undefined && { temperature: temperatureToUse }),
     });
     res.setHeader('Transfer-Encoding', 'chunked');
     res.setHeader('Content-Type', 'application/octet-stream');

apps/chat/src/store/conversations/conversations.epics.ts

@@ -120,7 +120,6 @@ import { LOCAL_BUCKET } from '@/src/constants/chat';
 import {
   DEFAULT_CONVERSATION_NAME,
   DEFAULT_TEMPERATURE,
-  FALLBACK_TEMPERATURE,
 } from '@/src/constants/default-ui-settings';
 import { errorsMessages } from '@/src/constants/errors';
 import { DEFAULT_EXTERNAL_APPS_SCHEMA_ID } from '@/src/constants/external-apps';
@@ -1520,17 +1519,18 @@ const streamMessageEpic: AppEpic = (action$, state$) =>
       const modelsMap = ModelsSelectors.selectModelsMap(state$.value);
       const lastModel = modelsMap[payload.conversation.model.id];
       const conversationModelType = lastModel?.type ?? EntityType.Model;
-      let modelAdditionalSettings = {};
+      const modelAdditionalSettings: Partial<
+        Pick<ChatBody, 'prompt' | 'temperature'>
+      > = {};
 
       if (conversationModelType === EntityType.Model) {
-        modelAdditionalSettings = {
-          prompt: doesModelAllowSystemPrompt(lastModel)
-            ? payload.conversation.prompt
-            : undefined,
-          temperature: doesModelAllowTemperature(lastModel)
-            ? payload.conversation.temperature
-            : FALLBACK_TEMPERATURE,
-        };
+        if (doesModelAllowSystemPrompt(lastModel)) {
+          modelAdditionalSettings.prompt = payload.conversation.prompt;
+        }
+        if (doesModelAllowTemperature(lastModel)) {
+          modelAdditionalSettings.temperature =
+            payload.conversation.temperature;
+        }
       }
 
       const chatBody: ChatBody = {

apps/chat/src/utils/server/index.ts

@@ -63,13 +63,13 @@ export const OpenAIStream = async ({
   configurationSchemaValue,
 }: {
   model: DialAIEntityModel;
-  temperature: number | undefined;
   messages: Message[];
   userJWT: string;
   chatReference: string;
   jobTitle: string | undefined;
   maxRequestTokens: number | undefined;
   configurationSchemaValue?: MessageFormValue;
+  temperature?: number;
 }) => {
   let messagesToSend = messages;
   const url = getUrl(model);