[BUG] SSMS extension versions?

[ZedZipDev]

Component

Desktop App (Windows)

Performance Studio Version

1.13.0

Operating System

Windows 11

Describe the Bug

I have installed and VSIX detected SSMS 21, SSMS 22 in my system and installed extension for both of them.
But what means
"Supports SSMS 17 SSMS 18"

in the gallery ?

It should be
Supports SSMS 21 SSMS 22

Steps to Reproduce

Check the SSMS extensions gallery

Expected Behavior

Supports SSMS 21 SSMS 22

Actual Behavior

Supports SSMS 17 SSMS 18 - ?

It supports SSMS 21 , SSMS 22 but does not support these very old SSMS 17 SSMS 18

Plan File

No response

Screenshots

No response

[erikdarlingdata]

Thanks for the report — and good news: the extension does fully support SSMS 21 and 22. That's exactly what it installs into and what we build and test against, so you're good to use it.

The "Supports SSMS 17 SSMS 18" text is a display quirk on the SSMS Gallery site, not a real compatibility limit. SSMS extensions target the underlying Visual Studio shell version, and SSMS 21/22 are built on VS shell 17/18. Our manifest correctly targets [17.0,) (VS shell 17 and up = SSMS 21/22), but the gallery is printing the raw shell numbers with an "SSMS" prefix, so it reads "17/18" instead of "21/22". We can't change the manifest to say 21/22 — the InstallationTarget version has to be the VS shell version or VSIXInstaller won't install the extension at all.

I've added "Compatible with SSMS 21 and SSMS 22" to the extension description so it's clearer in the gallery in the meantime.

---

cc @ErikEJ — this is a label bug on the gallery side. In VsixGallery/src/Code/Package.cs, GetFriendlyTargetsFromInstallationTargets() does names.Add($"SSMS {major}") using the VS shell major, so a [17.0,) target renders as "SSMS 17 / SSMS 18". The method's own docstring already expects "SSMS 21", so the code and its documented intent disagree. A shell-major → SSMS-version map on the isSsms branch (17→21, 18→22, with a graceful fallback) would fix it. Issues are disabled on that repo — happy to send a PR if it's useful.

[ErikEJ]

@erikdarlingdata Actually, I believe you can change to 21.0 range!

[ErikEJ]

@erikdarlingdata My extensions have, this, but could probably also be [21.0,) if support for a very old SSMS version is a must

<InstallationTarget Id="Microsoft.VisualStudio.Ssms" Version="[22.0,)">
      <ProductArchitecture>amd64</ProductArchitecture>
    </InstallationTarget>
    <InstallationTarget Id="Microsoft.VisualStudio.Ssms" Version="[22.0,)">
      <ProductArchitecture>arm64</ProductArchitecture>
</InstallationTarget>

[erikdarlingdata]

@ErikEJ you're right — thanks for the correction. I verified against your SqlCeToolbox manifest (and a couple of other SSMS extensions): the version under Microsoft.VisualStudio.Ssms is the SSMS product version, not the VS shell version, so [21.0,23.0) is the canonical "SSMS 21 and 22" range.

Our [17.0,) did install fine (21 and 22 are both ≥ 17), but the gallery was faithfully rendering the lower bound as "SSMS 17" — so this was on our side, not the gallery's. Please disregard my earlier "gallery bug" note.

I've switched the manifest to [21.0,23.0), which fixes the label at the source with no gallery change needed. It'll show "SSMS 21 / SSMS 22" in the gallery from the next release.

[ErikEJ]

@erikdarlingdata You are very welcome!

[erikdarlingdata]

Fixed in #371 (merged to dev) — the manifest now targets [21.0,23.0), so the gallery will show "SSMS 21 / SSMS 22" from the next release. Thanks again @ZedZipDev for the report and @ErikEJ for the correction.