Merge pull request #198 from estie-inc/refactor/unify-default-new-constructors

refactor(config): provide new() on public config types and unify Default/new convention

Author: yuly3

README.md

@@ -14,13 +14,13 @@ struct ExampleRow {
     value: String,
 }
 
-let session_config = SessionConfig::default()
+let session_config = SessionConfig::new()
     .with_role("ROLE")
     .with_warehouse("WAREHOUSE")
     .with_database("DATABASE")
     .with_schema("SCHEMA");
 
-let query_config = QueryConfig::default()
+let query_config = QueryConfig::new()
     // Client-side timeout for obtaining a query response.
     .with_query_response_timeout(std::time::Duration::from_secs(60));
 
@@ -221,7 +221,7 @@ let proxy = ProxyConfig::new(
 )
 .with_basic_auth("proxy_user", "proxy_pass");
 
-let transport = TransportConfig::default().with_proxy(proxy);
+let transport = TransportConfig::new().with_proxy(proxy);
 let client = Client::new(
     ClientConfig::new("USERNAME", "ACCOUNT", auth)
         .with_transport(transport),

examples/derive_from_row.rs

@@ -46,7 +46,7 @@ fn main() -> std::result::Result<(), Box<dyn std::error::Error>> {
 }
 
 async fn async_main() -> Result<()> {
-    let client = connect_with_configs(session_config(), QueryConfig::default())?;
+    let client = connect_with_configs(session_config(), QueryConfig::new())?;
     let session = client.create_session().await?;
 
     run_default_mapping_example(&session).await?;
@@ -201,7 +201,7 @@ fn session_config() -> SessionConfig {
     let database = env::var("SNOWFLAKE_DATABASE").ok();
     let schema = env::var("SNOWFLAKE_SCHEMA").ok();
 
-    let mut session_config = SessionConfig::default();
+    let mut session_config = SessionConfig::new();
     if let Some(warehouse) = warehouse {
         session_config = session_config.with_warehouse(warehouse);
     }

examples/external_browser_sso.rs

@@ -13,7 +13,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let database = env::var("SNOWFLAKE_DATABASE").ok();
     let schema = env::var("SNOWFLAKE_SCHEMA").ok();
 
-    let mut session_config = SessionConfig::default();
+    let mut session_config = SessionConfig::new();
     if let Some(warehouse) = warehouse {
         session_config = session_config.with_warehouse(warehouse);
     }

examples/external_browser_sso_without_callback_listener.rs

@@ -15,7 +15,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let external_browser =
         ExternalBrowserConfig::manual_redirect(BrowserLaunchMode::Manual, redirect_port);
 
-    let mut session_config = SessionConfig::default();
+    let mut session_config = SessionConfig::new();
     if let Some(warehouse) = warehouse {
         session_config = session_config.with_warehouse(warehouse);
     }

examples/statement_bind.rs

@@ -145,7 +145,7 @@ async fn build_session() -> std::result::Result<Session, Box<dyn std::error::Err
     let database = env::var("SNOWFLAKE_DATABASE").ok();
     let schema = env::var("SNOWFLAKE_SCHEMA").ok();
 
-    let mut session_config = SessionConfig::default();
+    let mut session_config = SessionConfig::new();
     if let Some(value) = warehouse {
         session_config = session_config.with_warehouse(value);
     }

src/auth/external_browser/config.rs

@@ -116,8 +116,7 @@ impl Default for ExternalBrowserConfig {
 impl ExternalBrowserConfig {
     /// Creates a callback-listener external-browser configuration.
     ///
-    /// This mode starts a local HTTP listener and receives the token automatically
-    /// from the redirected callback URL.
+    /// This mode starts a local HTTP listener and receives the token automatically from the redirected callback URL.
     ///
     /// - `browser_launch_mode`: controls whether the auth URL is opened automatically (`Auto`) or only printed for manual open (`Manual`).
     /// - `callback_socket_addr`: bind address for the local callback listener (for example `127.0.0.1` or `0.0.0.0`).

src/config.rs

@@ -161,6 +161,10 @@ impl ClientConfig {
 }
 
 impl SessionConfig {
+    pub fn new() -> Self {
+        Self::default()
+    }
+
     pub fn with_warehouse(mut self, warehouse: impl Into<String>) -> Self {
         self.warehouse = Some(warehouse.into());
         self
@@ -200,6 +204,10 @@ impl SessionConfig {
 }
 
 impl QueryConfig {
+    pub fn new() -> Self {
+        Self::default()
+    }
+
     /// Sets the client-side timeout for obtaining a query response from Snowflake.
     ///
     /// This bounds how long [`Session::query()`](crate::Session::query) /
@@ -394,6 +402,10 @@ fn validate_custom_base_url(mut url: Url) -> Result<Url> {
 }
 
 impl TransportConfig {
+    pub fn new() -> Self {
+        Self::default()
+    }
+
     pub fn with_proxy(mut self, proxy: ProxyConfig) -> Self {
         self.proxy = Some(proxy);
         self

src/result_cursor/collect.rs

@@ -11,16 +11,14 @@ use crate::{
 use super::{model::ResultSnapshot, remote::PartitionSource};
 
 /// Options for controlling how result-set collection fetches remaining partitions.
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, Default)]
 pub struct CollectOptions {
     pub(crate) prefetch_concurrency: Option<NonZeroUsize>,
 }
 
 impl CollectOptions {
     pub fn new() -> Self {
-        Self {
-            prefetch_concurrency: None,
-        }
+        Self::default()
     }
 
     /// Overrides the connection's default prefetch concurrency for this collect call.
@@ -30,12 +28,6 @@ impl CollectOptions {
     }
 }
 
-impl Default for CollectOptions {
-    fn default() -> Self {
-        Self::new()
-    }
-}
-
 #[derive(Clone, Copy)]
 pub(crate) struct CollectPolicy {
     pub(crate) prefetch_concurrency: NonZeroUsize,