As it stands, we can make code changes that break Tenderly simulations and we don't have any tests to tell us. We only find this out when we manually check the Tenderly links ourselves.
We should avoid the need for these discussions in the future:
One possible solution here is to make sure that the simulation doesn't revert. This might mean making a request to the tenderly API. Base contracts solves this by using their simulation function. However, we can't use this because we simulate a different way and it causes errors trying to simulate twice in the same EVM instance.
As it stands, we can make code changes that break Tenderly simulations and we don't have any tests to tell us. We only find this out when we manually check the Tenderly links ourselves.
We should avoid the need for these discussions in the future:
One possible solution here is to make sure that the simulation doesn't revert. This might mean making a request to the tenderly API. Base contracts solves this by using their simulation function. However, we can't use this because we simulate a different way and it causes errors trying to simulate twice in the same EVM instance.