fix(api): default /js to bundled container asset

Author: evannotfound

apps/api/.env.example

@@ -1,4 +1,9 @@
 PORT=8080
 REDIS_URL=
-SCRIPT_PATH=../web/public/js/client.min.js
 DEBUG=false
+
+# Optional override for the served /js asset path.
+# When unset, the API automatically uses the built-in container copy at
+# /app/public/js/client.min.js if present, otherwise it falls back to the
+# local source-run path at ../web/public/js/client.min.js.
+# SCRIPT_PATH=

apps/api/Dockerfile

@@ -40,7 +40,6 @@ COPY --from=api-builder /out/vercount-api /app/vercount-api
 COPY --from=web-builder /src/apps/web/public/js/client.min.js /app/public/js/client.min.js
 
 ENV PORT=8080
-ENV SCRIPT_PATH=/app/public/js/client.min.js
 
 EXPOSE 8080
 

apps/api/README.md

@@ -15,7 +15,7 @@ Copy `.env.example` to `.env` and set:
 
 - `REDIS_URL` - direct Redis connection URL for the existing counter backend
 - `PORT` - HTTP port (default `8080`)
-- `SCRIPT_PATH` - path to the built browser script (default `../web/public/js/client.min.js`)
+- `SCRIPT_PATH` - optional override for the browser script path used for `/js`
 - `DEBUG` - set to `true` for debug logs
 
 ## Run
@@ -44,7 +44,8 @@ Build the local API image from the repo root:
 pnpm api:docker:build
 ```
 
-The image build includes the built browser script for `/js`, so the runtime container does not depend on a host-local `apps/web/public/js/client.min.js` path.
+The image build includes the built browser script for `/js`, and the API uses that bundled copy automatically inside the container.
+`SCRIPT_PATH` remains available as an override if you ever need to point at a different file.
 
 ## Docker Compose
 
@@ -57,6 +58,7 @@ pnpm api:compose
 ```
 
 This uses `compose.yaml`, starts the published GHCR image from the repository root, and keeps using your existing Redis backend.
+If you need to override the bundled `/js` file path for a one-off run, set `SCRIPT_PATH` in the shell before starting Compose.
 
 The production-like Compose file uses:
 
@@ -73,6 +75,7 @@ pnpm api:compose:local
 ```
 
 This uses `compose-local.yaml`, builds the API image locally, and wires the API container to `redis://redis:6379/0`.
+It also defaults to the bundled in-image `/js` asset, with `SCRIPT_PATH` still available as a one-off shell override.
 
 Stop the production-like Compose workflow from the repo root with:
 

apps/api/internal/app/config.go

@@ -6,6 +6,11 @@ import (
 	"strings"
 )
 
+const (
+	containerScriptPath = "/app/public/js/client.min.js"
+	localScriptPath     = "../web/public/js/client.min.js"
+)
+
 type Config struct {
 	Addr       string
 	RedisURL   string
@@ -29,10 +34,7 @@ func LoadConfig() (Config, error) {
 		return Config{}, fmt.Errorf("REDIS_URL is required")
 	}
 
-	scriptPath := strings.TrimSpace(os.Getenv("SCRIPT_PATH"))
-	if scriptPath == "" {
-		scriptPath = "../web/public/js/client.min.js"
-	}
+	scriptPath := resolveScriptPath()
 
 	debug := strings.EqualFold(strings.TrimSpace(os.Getenv("DEBUG")), "true")
 
@@ -77,3 +79,15 @@ func LoadEnvFile(path string) error {
 
 	return nil
 }
+
+func resolveScriptPath() string {
+	if override := strings.TrimSpace(os.Getenv("SCRIPT_PATH")); override != "" {
+		return override
+	}
+
+	if _, err := os.Stat(containerScriptPath); err == nil {
+		return containerScriptPath
+	}
+
+	return localScriptPath
+}

compose-local.yaml

@@ -7,7 +7,7 @@ services:
     environment:
       PORT: ${API_PORT:-8080}
       REDIS_URL: redis://redis:6379/0
-      SCRIPT_PATH: /app/public/js/client.min.js
+      SCRIPT_PATH: ${SCRIPT_PATH:-}
       DEBUG: ${DEBUG:-false}
     depends_on:
       - redis

compose.yaml

@@ -5,7 +5,7 @@ services:
       - ./apps/api/.env
     environment:
       PORT: ${API_PORT:-8080}
-      SCRIPT_PATH: /app/public/js/client.min.js
+      SCRIPT_PATH: ${SCRIPT_PATH:-}
     ports:
       - "${API_PORT:-8080}:8080"
     restart: unless-stopped