Skip to content

Commit 79cd9b4

Browse files
committed
Merge branch 'dev' into e2e-integrate
2 parents eef4bfb + 41df248 commit 79cd9b4

8 files changed

Lines changed: 29 additions & 24 deletions

File tree

packages/evershop/src/modules/auth/pages/admin/adminLogin/LoginForm.tsx

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,13 @@ interface LoginFormProps {
1212
dashboardUrl: string;
1313
}
1414

15-
const SubmitButton: React.FC<{ formId: string }> = ({ formId }) => {
15+
const SubmitButton: React.FC = () => {
1616
const {
1717
formState: { isSubmitting }
1818
} = useFormContext();
1919
return (
2020
<div className="form-submit-button flex border-t border-border mt-4 pt-4 justify-between">
21-
<Button
22-
onClick={() => {
23-
(document.getElementById(formId) as HTMLFormElement).dispatchEvent(
24-
new Event('submit', { cancelable: true, bubbles: true })
25-
);
26-
}}
27-
size="lg"
28-
isLoading={isSubmitting}
29-
>
21+
<Button type="submit" size="lg" isLoading={isSubmitting}>
3022
SIGN IN
3123
</Button>
3224
</div>
@@ -122,7 +114,7 @@ export default function LoginForm({ authUrl, dashboardUrl }: LoginFormProps) {
122114
},
123115
{
124116
component: {
125-
default: <SubmitButton formId="adminLoginForm" />
117+
default: <SubmitButton />
126118
},
127119
sortOrder: 30
128120
}

packages/evershop/src/modules/oms/pages/admin/orderEdit/AddTrackingButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ export default function AddTrackingButton({
101101
<DialogClose>
102102
<Button
103103
title="Cancel"
104-
variant="destructive"
104+
variant="outline"
105105
onClick={() => {
106106
setDialogOpen(false);
107107
}}

packages/evershop/src/modules/oms/pages/admin/orderEdit/Customer.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,11 @@ export default function Customer({
9090
<CardContent className="border-t border-border pt-3">
9191
<CardTitle className="mb-2">Shipping Address</CardTitle>
9292
{!noShippingRequired && <AddressSummary address={shippingAddress} />}
93-
{noShippingRequired && <span>{'No shipping required'}</span>}
93+
{noShippingRequired && (
94+
<span className="text-muted-foreground">
95+
{'No shipping required'}
96+
</span>
97+
)}
9498
</CardContent>
9599
<CardContent className="border-t border-border pt-3">
96100
<CardTitle className="mb-2">Billing address</CardTitle>

packages/evershop/src/modules/oms/pages/admin/orderEdit/Items.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export default function Items({ order: { items, shipmentStatus } }) {
2727
</CardTitle>
2828
</CardHeader>
2929
<CardContent>
30-
<Table>
30+
<Table className="table-fixed">
3131
<TableBody>
3232
{items.map((i, k) => (
3333
<TableRow key={k}>
@@ -64,7 +64,8 @@ export default function Items({ order: { items, shipmentStatus } }) {
6464
component: { default: 'td' },
6565
props: {
6666
children: <span>{i.lineTotal.text}</span>,
67-
key: 'lineTotal'
67+
key: 'lineTotal',
68+
className: 'w-20 whitespace-nowrap text-right'
6869
},
6970
sortOrder: 40,
7071
id: 'lineTotal'

packages/evershop/src/modules/oms/pages/admin/orderEdit/ShipButton.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@ export default function ShipButton({
3030
}: ShipButtonProps) {
3131
const { openAlert, closeAlert, dispatchAlert } = useAlertContext();
3232
if (noShippingRequired) {
33-
return <Button title="No Shipping Required" variant="secondary" />;
33+
return (
34+
<Button disabled variant="secondary">
35+
No Shipping Required
36+
</Button>
37+
);
3438
}
3539
if (shipment) {
3640
return null;
@@ -91,7 +95,7 @@ export default function ShipButton({
9195
primaryAction: {
9296
title: 'Cancel',
9397
onAction: closeAlert,
94-
variant: ''
98+
variant: 'outline'
9599
},
96100
secondaryAction: {
97101
title: 'Ship',
@@ -106,7 +110,7 @@ export default function ShipButton({
106110
new Event('submit', { cancelable: true, bubbles: true })
107111
);
108112
},
109-
variant: 'secondary',
113+
variant: 'default',
110114
isLoading: false
111115
}
112116
});

packages/evershop/src/modules/oms/pages/admin/orderEdit/items/Name.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,19 @@ export function Name({
1818
productUrl,
1919
variantOptions = []
2020
}: NameProps) {
21+
const truncatedName = name.length > 30 ? `${name.substring(0, 30)}...` : name;
22+
2123
return (
22-
<TableCell>
23-
<div className="product-column">
24+
<TableCell className="w-auto min-w-0">
25+
<div className="product-column overflow-hidden">
2426
<div>
2527
<span className="font-semibold">
26-
<a href={productUrl}>{name}</a>
28+
<a href={productUrl} title={name}>
29+
{truncatedName}
30+
</a>
2731
</span>
2832
</div>
29-
<div className="text-gray-500">
33+
<div className="text-muted-foreground">
3034
<span className="font-semibold">SKU: </span>
3135
<span>{productSku}</span>
3236
</div>

packages/evershop/src/modules/oms/pages/admin/orderEdit/items/Price.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ interface PriceProps {
88

99
export function Price({ price, qty }: PriceProps) {
1010
return (
11-
<TableCell>
11+
<TableCell className="w-32 whitespace-nowrap">
1212
<div className="product-price">
1313
<span>
1414
{price} x {qty}

packages/evershop/src/modules/oms/pages/admin/orderEdit/items/Thumbnail.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ interface ThumbnailProps {
88

99
export function Thumbnail({ imageUrl, qty }: ThumbnailProps) {
1010
return (
11-
<TableCell>
11+
<TableCell className="w-20">
1212
<div className="relative w-12 h-12 flex justify-center border border-divider rounded-[3px] p-0.5 box-border">
1313
<div className="self-center text-border">
1414
{imageUrl && (

0 commit comments

Comments
 (0)