feat: Fix 500 error on notes field being too long

exler · exler · commit 1d4224c00e96 · 2026-03-17T18:14:34.000+01:00
diff --git a/dome/templates/base.html b/dome/templates/base.html
@@ -40,6 +40,8 @@
         <link rel="manifest" href="{% url 'manifest' %}">
         <script src="{% static 'js/alpinejs-3.15.2.min.js' %}" defer></script>
         <script src="{% static 'js/htmx-2.0.7.min.js' %}" defer></script>
+        <!-- https://htmx.org/quirks/#by-default-4xx-5xx-responses-do-not-swap  -->
+        <meta name="htmx-config" content='{"responseHandling": [{"code":".*", "swap": true}]}' /> <!-- All responses are swapped -->
     </head>
     <body class="bg-gray-50">
         <div class="max-w-5xl mx-auto">
diff --git a/entities/models.py b/entities/models.py
@@ -5,7 +5,6 @@
 
 from django.core.validators import MaxLengthValidator
 from django.db import models
-from django.db.models.functions import Lower
 from django.urls import reverse
 from django.utils.translation import gettext_lazy as _
 
diff --git a/entities/templates/entities/entities_detail.html b/entities/templates/entities/entities_detail.html
@@ -108,6 +108,23 @@ <h1 class="text-3xl font-bold mb-2">{{ object.name }}</h1>
                 </p>
             {% endif %}
 
+            <!-- Tracking Form Errors -->
+            {% if form.errors %}
+                <div class="border-3 border-black bg-red-100 p-4 mb-4">
+                    <h3 class="font-bold text-xs uppercase mb-2">Could not save changes</h3>
+                    <ul class="list-disc list-inside text-xs text-red-700">
+                        {% for field in form %}
+                            {% for error in field.errors %}
+                                <li>{{ field.label }}: {{ error }}</li>
+                            {% endfor %}
+                        {% endfor %}
+                        {% for error in form.non_field_errors %}
+                            <li>{{ error }}</li>
+                        {% endfor %}
+                    </ul>
+                </div>
+            {% endif %}
+
             <!-- Status and Rating Box -->
             <div x-data="{ statusDropdownOpen: false, ratingDropdownOpen: false, hoverIndex: null }"
                  class="neo-box p-4 mb-6">
diff --git a/tracking/migrations/0003_alter_trackingobject_notes.py b/tracking/migrations/0003_alter_trackingobject_notes.py
@@ -0,0 +1,18 @@
+# Generated by Django 6.0.2 on 2026-03-17 17:13
+
+import django.core.validators
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("tracking", "0002_initial"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="trackingobject",
+            name="notes",
+            field=models.TextField(blank=True, validators=[django.core.validators.MaxLengthValidator(500)]),
+        ),
+    ]
diff --git a/tracking/models.py b/tracking/models.py
@@ -28,7 +28,7 @@ class Status(models.IntegerChoices):
     rating = models.PositiveSmallIntegerField(
         null=True, blank=True, validators=[MinValueValidator(1), MaxValueValidator(5)]
     )
-    notes = models.TextField(blank=True, validators=[MaxLengthValidator(150)])
+    notes = models.TextField(blank=True, validators=[MaxLengthValidator(500)])
 
     class Meta:
         indexes: ClassVar = [
diff --git a/tracking/views.py b/tracking/views.py
@@ -104,6 +104,14 @@ def form_valid(self: Self, form: ModelForm) -> HttpResponse:
             self.request, "entities/entities_detail.html", {"object": self.entity, "tracking_obj": self.object}
         )
 
+    def form_invalid(self: Self, form: ModelForm) -> HttpResponse:
+        return render(
+            self.request,
+            "entities/entities_detail.html",
+            {"object": self.entity, "tracking_obj": self.object, "form": form},
+            status=400,
+        )
+
     def get_context_data(self: Self, **kwargs: Any) -> dict[str, Any]:
         context = super().get_context_data(**kwargs)
         context["entity"] = self.entity

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ class Status(models.IntegerChoices):`
`28`	`28`	`rating = models.PositiveSmallIntegerField(`
`29`	`29`	`null=True, blank=True, validators=[MinValueValidator(1), MaxValueValidator(5)]`
`30`	`30`	`)`
`31`		`- notes = models.TextField(blank=True, validators=[MaxLengthValidator(150)])`
	`31`	`+ notes = models.TextField(blank=True, validators=[MaxLengthValidator(500)])`
`32`	`32`
`33`	`33`	`class Meta:`
`34`	`34`	`indexes: ClassVar = [`