Skip to content

Commit cde3d8b

Browse files
Remove eslint-plugin-import. It is not works very well with editor linters.
1 parent 70866c7 commit cde3d8b

4 files changed

Lines changed: 31 additions & 56 deletions

File tree

CHANGELOG.md

Lines changed: 25 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
1-
1.0.0 (Not Released Yet)
2-
========================
1+
# 1.0.0 (Not Released Yet)
32

4-
1.0.0-beta.7 (2016-08-24)
5-
=========================
3+
## 1.0.0-beta.8 (2016-08-24)
4+
5+
* Disable `eslint-plugin-import` as it breaks Sublime Text & Atom ESLint
6+
integration. Return `eslint-plugin-import-order` plugin back.
7+
8+
## 1.0.0-beta.7 (2016-08-24)
69

710
* Bump:
811
* `eslint` to `3.3.1`
@@ -20,67 +23,57 @@
2023
* Remove `object-assign` from project dependencies
2124
* Move to node.js `v4.5.0` for development
2225

23-
1.0.0-beta.6 (2016-07-29)
24-
=========================
26+
## 1.0.0-beta.6 (2016-07-29)
2527

2628
* Fix `react/no-string-refs` rule in `ezhome/alternate` config.
2729

28-
1.0.0-beta.5 (2016-07-29)
29-
=========================
30+
## 1.0.0-beta.5 (2016-07-29)
3031

3132
* Require node.js 4 LTS or higher and npm 3 to use `eslint-config-ezhome`
3233
* Install ESLint dependencies via `package.json`, which results in unnecessary
3334
to install them via `devDependencies`
3435
* New rule to `ezhome/alternate` config:
3536
* `react/jsx-no-string-refs`
3637

37-
1.0.0-beta.4 (2016-07-20)
38-
=========================
38+
## 1.0.0-beta.4 (2016-07-20)
3939

4040
* Enable [eslint-plugin-import-order](https://github.com/jfmengels/eslint-plugin-import-order)
4141
plugin
4242
* New rules:
4343
* `react/jsx-indent`
4444
* `react/no-deprecated`
4545

46-
1.0.0-beta.3 (2016-07-20)
47-
=========================
46+
## 1.0.0-beta.3 (2016-07-20)
4847

4948
* Set maximum line length to 120 characters in alternate config
5049

51-
1.0.0-beta.2 (2016-06-22)
52-
=========================
50+
## 1.0.0-beta.2 (2016-06-22)
5351

5452
* Update rules for ternary operator.
5553

56-
1.0.0-beta.1 (2016-05-12)
57-
=========================
54+
## 1.0.0-beta.1 (2016-05-12)
5855

5956
* Migrate to node@4.4.3, eslint@2.9.0, babel-eslint@6.0.2 and
6057
eslint-plugin-react@5.1.1
6158

62-
0.6.1 (2015-12-18)
63-
==================
59+
# 0.6.1 (2015-12-18)
6460

6561
* Fix config for non-React projects. Do not list `react` plugin if it not
6662
installed.
6763

68-
0.6.0 (2015-12-18)
69-
==================
64+
# 0.6.0 (2015-12-18)
7065

7166
* Enable `eslint-plugin-react` rules only if plugin installed and available
7267

73-
0.5.0 (2015-12-02)
74-
==================
68+
# 0.5.0 (2015-12-02)
7569

7670
* Moved `react/jsx-handler-names` rule to `ezhome/alternate` config
7771
* Increase maximum of props for one line in `react/jsx-max-props-per-line` rule
7872
to 4
7973
* Removed `.eslintrc` from the repo, put default config as `eslintConfig`
8074
object to `package.json`
8175

82-
0.5.0-beta (2015-12-02)
83-
=======================
76+
## 0.5.0-beta (2015-12-02)
8477

8578
* Disable `no-eq-null` rule
8679
* Update ESLint required version to 1.10.3 and ESLint react Plugin to 3.11.2
@@ -91,28 +84,24 @@
9184
* `react/jsx-pascal-case`
9285
* `react/no-direct-mutation-state`
9386

94-
0.4.0 (2015-10-29)
95-
==================
87+
# 0.4.0 (2015-10-29)
9688

9789
* Add `react/prefer-es6-class` rule
9890
* List preferred versions for ESLint stack dependencies
9991

100-
0.3.0 (2015-09-24)
101-
==================
92+
# 0.3.0 (2015-09-24)
10293

10394
Final release after 2 betas and 2 release candidates. No changes compared
10495
to `0.3.0-rc2`.
10596

106-
0.3.0-rc2 (2015-09-21)
107-
----------------------
97+
## 0.3.0-rc2 (2015-09-21)
10898

10999
* Bump requirements, now `eslint-config-ezhome` requires ESLint 1.5.0 and
110100
ESLint React plugin 3.4.2
111101
* Add new `react/jsx-closing-bracket-location` rule
112102
* Use `jsx-quotes` instead of `react/jsx-quotes` rule
113103

114-
0.3.0-rc1 (2015-09-14)
115-
----------------------
104+
## 0.3.0-rc1 (2015-09-14)
116105

117106
* Move `ezhome` to `ezhome/base` config. This config should be used to projects
118107
that still uses ES5.
@@ -125,22 +114,19 @@ to `0.3.0-rc2`.
125114
* Provide alternate config which enables comma-dangling and uses 2 spaces for
126115
indent in JS and JSX blocks. This config now available as `ezhome/alternate`.
127116

128-
0.3.0-beta2 (2015-09-05)
129-
------------------------
117+
## 0.3.0-beta2 (2015-09-05)
130118

131119
* Fixes to previous beta release
132120

133-
0.3.0-beta (2015-09-05)
134-
-----------------------
121+
## 0.3.0-beta (2015-09-05)
135122

136123
* Update ESLint React rules by:
137124
* Adding `react/jsx-curly-spacing` rule
138125
* Adding `react/jsx-indent-props` rule
139126
* Adding `react/jsx-no-duplicate-props` rule
140127
* Adding `react/jsx-sort-props` rule
141128

142-
0.2.0 (2015-08-30)
143-
==================
129+
# 0.2.0 (2015-08-30)
144130

145131
* Fix ESLint config by:
146132
* Adding `eol-last` rule
@@ -150,7 +136,6 @@ to `0.3.0-rc2`.
150136
* Adding `semi` rule
151137
* Adding `spaced-comment` rule
152138

153-
0.1.0 (2015-08-20)
154-
==================
139+
# 0.1.0 (2015-08-20)
155140

156141
* Initial Release

base/index.js

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -71,19 +71,9 @@ var config = {
7171
}
7272
};
7373

74-
if (utils.importPluginInstalled) {
75-
config.extends.push("plugin:import/errors");
76-
config.plugins.push("import");
77-
78-
config.rules = Object.assign({}, config.rules, {
79-
"import/imports-first": 2,
80-
"import/newline-after-import": 2,
81-
"import/no-amd": 2,
82-
"import/no-duplicates": 2,
83-
"import/no-restricted-paths": 2,
84-
"import/order": [2, {"newlines-between": "always"}],
85-
"import/prefer-default-export": 2
86-
});
74+
if (utils.importOrderPluginInstalled) {
75+
config.extends.push("plugin:import-order/recommended");
76+
config.plugins.push("import-order");
8777
}
8878

8979
if (utils.reactPluginInstalled) {

base/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ var hasModuleInstalled = function(name) {
99
};
1010

1111
module.exports = {
12-
importPluginInstalled: hasModuleInstalled("eslint-plugin-import"),
12+
importOrderPluginInstalled: hasModuleInstalled("eslint-plugin-import-order"),
1313
reactPluginInstalled: hasModuleInstalled("eslint-plugin-react")
1414
};

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "eslint-config-ezhome",
3-
"version": "1.0.0-beta.7",
3+
"version": "1.0.0-beta.8",
44
"author": "Ezhome Engineers",
55
"authorEmail": "engineers@ezhome.com",
66
"bugs": {
@@ -24,7 +24,7 @@
2424
"dependencies": {
2525
"babel-eslint": "6.1.2",
2626
"eslint": "3.3.1",
27-
"eslint-plugin-import": "1.14.0",
27+
"eslint-plugin-import-order": "2.1.4",
2828
"eslint-plugin-react": "6.1.2"
2929
},
3030
"engines": {

0 commit comments

Comments
 (0)