Merge pull request #685 from fable-hub/v3.0_fix_singleTupleInput

Fix single tuple input for ReactComponent #644 + tests ✅

Author: Freymaurer

src/Feliz.CompilerPlugins/CHANGELOG.md

@@ -16,6 +16,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## 3.0.0-rc.3 - 2025-11-03
+
+### 🐛 Fixed
+
+- Correctly call single tuple inputs for ReactComponent #644 by @Freymaurer
+
 ## 3.0.0-rc.2 - 2025-11-03
 
 ### 🔄 Changed

src/Feliz.CompilerPlugins/ReactComponent.fs

@@ -16,6 +16,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## 3.0.0-rc.6 - 2025-11-03
+
+### 🐛 Fixed
+
+- Correctly call single tuple inputs for ReactComponent #644 by @Freymaurer
+
 ## 3.0.0-rc.5 - 2025-11-07
 
 ### 🐛 Fixed

src/Feliz/CHANGELOG.md

@@ -787,6 +787,7 @@ type Html =
     static member inline text (value: float) : ReactElement = unbox value
     static member inline text (value: int) : ReactElement = unbox value
     static member inline text (value: string) : ReactElement = unbox value
+    static member inline text (value: bool) : ReactElement = unbox value
     static member inline text (value: System.Guid) : ReactElement = unbox (string value)
 
     static member inline textf fmt = Printf.kprintf Html.text fmt

src/Feliz/Html.fs

@@ -1799,6 +1799,9 @@ type prop =
     /// Defines the text content of the element. Alias for `children [ Html.text value ]`
     static member inline text (value: string) = PropHelper.mkAttr "children" [value]
 
+    /// Defines the text content of the element. Alias for `children [ Html.text value ]`
+    static member inline text (value: System.Guid) = PropHelper.mkAttr "children" [value.ToString()]
+
     /// Defines the text content of the element. Alias for `children [ Html.text (sprintf ...) ]`
     static member inline textf fmt = Printf.kprintf prop.text fmt
 

src/Feliz/Properties.fs

@@ -137,13 +137,38 @@ type Components =
             ]
         ]
 
-    // [<JSX.Component>]
-    // static member ConditionalProperty(?condition: bool) =
-    //     Html.div [
-    //         if condition.IsSome && condition.Value then
-    //             prop.className "conditional-class"
-    //             prop.onClick (fun _ -> Browser.Dom.console.log("Div clicked!"))
-    //         prop.children [
-    //             Html.div "Hello, World!"
-    //         ]
-    //     ]
+    [<ReactComponent>]
+    static member SingleTupleInput1(testing: (int * string * System.Guid)) =
+        let (a, b, c) = testing
+        Html.div [
+            Html.div [
+                prop.testId "int"
+                prop.text a
+            ]
+            Html.div [
+                prop.testId "string"
+                prop.text b
+            ]
+            Html.div [
+                prop.testId "guid"
+                prop.text c
+            ]
+        ]
+
+    [<ReactComponent>]
+    static member SingleTupleInput2(notTestingInsteadSomethingElse: (int * string * System.Guid)) =
+        let (a, b, c) = notTestingInsteadSomethingElse
+        Html.div [
+            Html.div [
+                prop.testId "int"
+                prop.text a
+            ]
+            Html.div [
+                prop.testId "string"
+                prop.text b
+            ]
+            Html.div [
+                prop.testId "guid"
+                prop.text c
+            ]
+        ]

tests/Feliz/Basic.fs

@@ -186,6 +186,28 @@ describe "Simple createElement calls" <| fun _ ->
         let text = render.getByText "42.42"
         expect(text).toBeInTheDocument()
 
+describe "Single Tuple Input Tests #644" <| fun _ ->
+
+    test "Component with single tuple input passes args correctly" <| fun _ ->
+        let guid = System.Guid.NewGuid()
+        RTL.render(
+            Components.SingleTupleInput1((42, "Test", guid))
+        ) |> ignore
+
+        expect(RTL.screen.getByTestId "int").toHaveTextContent("42")
+        expect(RTL.screen.getByTestId "string").toHaveTextContent("Test")
+        expect(RTL.screen.getByTestId "guid").toHaveTextContent(guid.ToString())
+
+    test "Component with single tuple input passes args correctly and with different argument name" <| fun _ ->
+        let guid = System.Guid.NewGuid()
+        RTL.render(
+            Components.SingleTupleInput2((42, "Test", guid))
+        ) |> ignore
+
+        expect(RTL.screen.getByTestId "int").toHaveTextContent("42")
+        expect(RTL.screen.getByTestId "string").toHaveTextContent("Test")
+        expect(RTL.screen.getByTestId "guid").toHaveTextContent(guid.ToString())
+
 describe "Basic Tests" <| fun _ ->
 
     test "Html elements can be rendered" <| fun _ ->