relax conditions on record type export #666

Author: Freymaurer

src/Feliz.CompilerPlugins/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Relax validation of record props defined along the react component to allow lower cased record types #463 #666 by @melanore
+
 ## 3.0.0-rc.1 - 2025-09-18
 
 ### Added

src/Feliz.CompilerPlugins/ReactComponent.fs

@@ -244,7 +244,7 @@ type ReactComponentAttribute(?exportDefault: bool, ?import: string, ?from:string
             if decl.Args.Length = 1 && AstUtils.isRecord compiler decl.Args[0].Type then
                 // check whether the record type is defined in this file
                 // trigger warning if that is case
-                let definedInThisFile =
+                let definedInThisFileAndIsUpperCase =
                     file.Declarations
                     |> List.tryPick (fun declaration ->
                         match declaration with
@@ -253,7 +253,9 @@ type ReactComponentAttribute(?exportDefault: bool, ?import: string, ?from:string
                             match decl.Args[0].Type with
                             | Type.DeclaredType (entity, _genericArgs) ->
                                 let declaredEntity = compiler.GetEntity(entity)
-                                if classEntity.IsFSharpRecord && declaredEntity.FullName = classEntity.FullName
+                                if classEntity.IsFSharpRecord 
+                                    && declaredEntity.FullName = classEntity.FullName
+                                    && (System.Char.IsUpper declaredEntity.CompiledName.[0])
                                 then Some declaredEntity.FullName
                                 else None
 
@@ -265,12 +267,12 @@ type ReactComponentAttribute(?exportDefault: bool, ?import: string, ?from:string
                             None
                     )
 
-                match definedInThisFile with
+                match definedInThisFileAndIsUpperCase with
                 | Some recordTypeName ->
                     let errorMsg = String.concat "" [
                         sprintf "Function component '%s' is using a record type '%s' as an input parameter. " decl.Name recordTypeName
                         "This happens to break React tooling like react-refresh and hot module reloading. "
-                        "To fix this issue, consider using an anonymous record instead or multiple simpler values as input parameters (can be tupled). "
+                        "To fix this issue, consider using instead: a lowercased record type, an anonymous record or multiple simpler values as input parameters (can be tupled). "
                         "Future versions of [<ReactComponent>] might not emit this warning anymore, in which case you can assume that the issue is fixed. "
                         "To learn more about the issue, see https://github.com/pmmmwh/react-refresh-webpack-plugin/issues/258"
                     ]

tests/Feliz/ExtractChildren.test.fs

@@ -133,8 +133,6 @@ describe "HtmlHelper.createElement" <| fun _ ->
                 "children", box child
             ]
         let extractedProps, childOption = HtmlHelper.extractByKeyFast "children" props
-        Browser.Dom.console.log(extractedProps)
-        Browser.Dom.console.log(childOption)
         expect(child).toBeTruthy()
         let key, child =
             match childOption with