Fix fuzzing tests for HTTPBinaryCodec for incompletely formed messages

Summary: Task T135622359 showed a fuzzing test failure where the HTTPBinaryCodec could crash on incompletely formed messages. This diff patches the issue.

Reviewed By: zhang00000

Differential Revision: D40861967

fbshipit-source-id: 3443686b37b972bff1a8839335b4df055f4552ba

Author: Shiv Kushwah

third-party/proxygen/src/proxygen/lib/http/codec/HTTPBinaryCodec.cpp

@@ -429,11 +429,20 @@ void HTTPBinaryCodec::onIngressEOF() {
         HTTPException(HTTPException::Direction::INGRESS,
                       fmt::format("Invalid Message: {}", *parseError_)));
   } else {
-    // Case where the sent message only contains control data
-    if (!msg_ && state_ == ParseState::HEADERS_SECTION) {
-      msg_ = std::move(decodeInfo_.msg);
+
+    if (!msg_) {
+      if (state_ == ParseState::HEADERS_SECTION) {
+        // Case where the sent message only contains control data
+        msg_ = std::move(decodeInfo_.msg);
+      } else {
+        callback_->onError(
+            ingressTxnID_,
+            HTTPException(
+                HTTPException::Direction::INGRESS,
+                fmt::format("Message not formed (incomplete binary data)")));
+        return;
+      }
     }
-    CHECK(msg_);
     callback_->onHeadersComplete(ingressTxnID_, std::move(msg_));
     if (msgBody_) {
       callback_->onBody(ingressTxnID_, std::move(msgBody_), 0);