feat(db): add rocksdb_options_{set,get}_allow_fallocate#14400
Closed
lveneris wants to merge 1 commit into
Closed
Conversation
lveneris
force-pushed
the
feat/db/set-allow-fallocate
branch
from
a22db66 to
50fb1f1
Compare
Author
|
Not sure who the best maintainer to contact about this would be. @hx235 can you provide guidance? This is, to the best of my knowledge, ready to go when someone gets time to look at it. |
Author
|
This seems to have been implemented at some point now so I'm going to close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure why this was missing, but here I have added the necessary functions for setting and getting the
allow_fallocateoption over FFI.References