Commit 7e96163
Add Scuba logging to MergeResolutionLostOnRetry invariant
Summary:
Add Scuba logging to the fail-closed invariant that detects when merge
resolution is lost during CAS retries. The existing ODS counter
(`merge_resolution_lost_on_retry`) fires but carries no investigation
context.
The new Scuba log writes to `mononoke_land_service` with:
- `log_tag=MergeResolutionLostOnRetry` for filtering
- `repo_name` for identifying the affected repository
- `retry_num` for understanding the retry context
- A descriptive violation message
This enables oncall to quickly investigate invariant violations by
querying `mononoke_land_service` with the log_tag filter, rather than
relying solely on an ODS counter spike.
Note: A separate ODS Alarm should be configured on
`mononoke.pushrebase.*.merge_resolution_lost_on_retry` to page the
oncall when this invariant fires.
Reviewed By: YousefSalama
Differential Revision: D99841012
fbshipit-source-id: 74ed319c7e4fb65b6694fa476fd27019af46c20b1 parent e8216e3 commit 7e96163
1 file changed
+13
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
910 | 910 | | |
911 | 911 | | |
912 | 912 | | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
913 | 926 | | |
914 | 927 | | |
915 | 928 | | |
| |||
0 commit comments