Skip to content

Commit 90ba943

Browse files
David Tolnaymeta-codesync[bot]
authored andcommitted
Fix clippy::borrowed_box lint in fbcode/eden/scm
Reviewed By: diliop Differential Revision: D99974194 fbshipit-source-id: 864d80e2a184cb7652f3a232c4ecaea661ead8c3
1 parent 9734ad2 commit 90ba943

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

eden/scm/lib/treestate/src/root.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ impl TreeStateRoot {
5959
self.dirty = true;
6060
}
6161

62-
pub fn metadata(&self) -> &Box<[u8]> {
62+
pub fn metadata(&self) -> &[u8] {
6363
&self.metadata
6464
}
6565

eden/scm/lib/treestate/src/serialization.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,19 @@ impl Serializable for AggregatedState {
9797
}
9898
}
9999

100-
impl Serializable for Box<[u8]> {
100+
impl Serializable for [u8] {
101101
fn serialize(&self, w: &mut dyn Write) -> Result<()> {
102102
w.write_vlq(self.len())?;
103103
w.write_all(self)?;
104104

105105
Ok(())
106106
}
107+
}
108+
109+
impl Serializable for Box<[u8]> {
110+
fn serialize(&self, w: &mut dyn Write) -> Result<()> {
111+
(**self).serialize(w)
112+
}
107113

108114
fn deserialize(r: &mut dyn Read) -> Result<Self> {
109115
let len: usize = r.read_vlq()?;

eden/scm/lib/treestate/src/treestate.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ use std::collections::HashMap;
1111
use std::fmt;
1212
use std::io::Cursor;
1313
use std::iter::Iterator;
14-
use std::ops::Deref;
1514
use std::path::Path;
1615
use std::path::PathBuf;
1716
use std::str::FromStr;
@@ -398,7 +397,7 @@ impl TreeState {
398397
}
399398

400399
pub fn metadata_bytes(&self) -> &[u8] {
401-
self.root.metadata().deref()
400+
self.root.metadata()
402401
}
403402

404403
pub fn metadata(&self) -> Result<BTreeMap<String, String>> {

0 commit comments

Comments
 (0)