Commit b9fd89c
Handle empty Scuba table in merge resolution blame checker
Summary:
When the mononoke_merge_resolution_alerts Scuba table has no data
(e.g. no alerts have been written yet), query_sql_as_dict raises
ValueError because the SQLQueryResult is not valid. This caused noisy
ERROR logs in the Chronos job output.
Fix: Catch ValueError in _query_scuba and return an empty list, since
an empty result is a valid outcome. Log at DEBUG level instead of
letting the exception propagate to callers that log at ERROR.
Reviewed By: YousefSalama
Differential Revision: D100162450
fbshipit-source-id: 908845cbff3446ab790f292a10ed85c1c8e0b2db1 parent a837ac9 commit b9fd89c
1 file changed
+17
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
155 | 164 | | |
156 | 165 | | |
157 | 166 | | |
| |||
0 commit comments