Skip to content

Commit 3a51236

Browse files
generatedunixname915440834509264meta-codesync[bot]
authored andcommitted
Fix CQS signal readability-braces-around-statements in fbcode/triton/tools
Reviewed By: FindHao Differential Revision: D95182284 fbshipit-source-id: 3b047c66a8dac1da7301c67f0c1baf6f8a95de8d
1 parent 6cc94b2 commit 3a51236

1 file changed

Lines changed: 39 additions & 13 deletions

File tree

src/trace_writer.cpp

Lines changed: 39 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -129,15 +129,21 @@ TraceWriter::~TraceWriter() {
129129
// ============================================================================
130130

131131
void TraceWriter::write_metadata(const nlohmann::json& metadata) {
132-
if (!enabled_) return;
132+
if (!enabled_) {
133+
return;
134+
}
133135
// Text mode (mode 0) does not use json_buffer_; skip.
134-
if (trace_mode_ == TraceMode::TEXT) return;
136+
if (trace_mode_ == TraceMode::TEXT) {
137+
return;
138+
}
135139

136140
json_buffer_ += metadata.dump() + "\n";
137141
}
138142

139143
bool TraceWriter::write_trace(const TraceRecord& record) {
140-
if (!enabled_) return false;
144+
if (!enabled_) {
145+
return false;
146+
}
141147

142148
// Dispatch based on trace mode
143149
if (trace_mode_ == TraceMode::TEXT) {
@@ -176,7 +182,9 @@ void serialize_common_fields(nlohmann::json& j, const T* data) {
176182
}
177183

178184
bool TraceWriter::write_data(const char* data, size_t size, const char* data_type) {
179-
if (fd_ < 0) return false;
185+
if (fd_ < 0) {
186+
return false;
187+
}
180188

181189
size_t total_written = 0;
182190

@@ -212,7 +220,9 @@ bool TraceWriter::write_data(const char* data, size_t size, const char* data_typ
212220
}
213221

214222
void TraceWriter::write_uncompressed() {
215-
if (json_buffer_.empty() || !enabled_) return;
223+
if (json_buffer_.empty() || !enabled_) {
224+
return;
225+
}
216226

217227
// CRITICAL FIX: Move json_buffer_ to temp to prevent data corruption
218228
//
@@ -256,7 +266,9 @@ void TraceWriter::write_clp_archive() {
256266
}
257267

258268
void TraceWriter::write_compressed() {
259-
if (json_buffer_.empty() || !enabled_ || !zstd_ctx_) return;
269+
if (json_buffer_.empty() || !enabled_ || !zstd_ctx_) {
270+
return;
271+
}
260272

261273
// CRITICAL FIX: Move json_buffer_ to temp to prevent data loss
262274
//
@@ -290,7 +302,9 @@ void TraceWriter::write_compressed() {
290302
}
291303

292304
void TraceWriter::serialize_reg_info(nlohmann::json& j, const reg_info_t* reg, const RegIndices* indices) {
293-
if (!reg) return;
305+
if (!reg) {
306+
return;
307+
}
294308

295309
using json = nlohmann::json;
296310

@@ -339,7 +353,9 @@ void TraceWriter::serialize_reg_info(nlohmann::json& j, const reg_info_t* reg, c
339353
}
340354

341355
void TraceWriter::serialize_mem_access(nlohmann::json& j, const mem_addr_access_t* mem) {
342-
if (!mem) return;
356+
if (!mem) {
357+
return;
358+
}
343359

344360
serialize_common_fields(j, mem);
345361

@@ -349,13 +365,17 @@ void TraceWriter::serialize_mem_access(nlohmann::json& j, const mem_addr_access_
349365
}
350366

351367
void TraceWriter::serialize_opcode_only(nlohmann::json& j, const opcode_only_t* opcode) {
352-
if (!opcode) return;
368+
if (!opcode) {
369+
return;
370+
}
353371

354372
serialize_common_fields(j, opcode);
355373
}
356374

357375
void TraceWriter::serialize_mem_value_access(nlohmann::json& j, const mem_value_access_t* mem) {
358-
if (!mem) return;
376+
if (!mem) {
377+
return;
378+
}
359379

360380
using json = nlohmann::json;
361381

@@ -373,7 +393,9 @@ void TraceWriter::serialize_mem_value_access(nlohmann::json& j, const mem_value_
373393
// Convert values array (32 lanes x up to 4 registers based on access_size)
374394
// Only include registers needed for the access size
375395
int regs_needed = (mem->access_size + 3) / 4;
376-
if (regs_needed > 4) regs_needed = 4;
396+
if (regs_needed > 4) {
397+
regs_needed = 4;
398+
}
377399

378400
json::array_t values_array;
379401
for (int lane = 0; lane < 32; lane++) {
@@ -387,7 +409,9 @@ void TraceWriter::serialize_mem_value_access(nlohmann::json& j, const mem_value_
387409
}
388410

389411
void TraceWriter::serialize_tma_access(nlohmann::json& j, const tma_access_t* tma) {
390-
if (!tma) return;
412+
if (!tma) {
413+
return;
414+
}
391415

392416
using json = nlohmann::json;
393417

@@ -413,7 +437,9 @@ void TraceWriter::serialize_tma_access(nlohmann::json& j, const tma_access_t* tm
413437
// ============================================================================
414438

415439
void TraceWriter::write_text_format(const TraceRecord& record) {
416-
if (!file_handle_) return;
440+
if (!file_handle_) {
441+
return;
442+
}
417443

418444
// Dispatch by trace type
419445
switch (record.type) {

0 commit comments

Comments
 (0)