Skip to content

Commit 0848cfb

Browse files
ahmadelyoussefmeta-codesync[bot]
authored andcommitted
Update DjangoBench MetaPython and CinderX revisions
Reviewed By: excelle08 Differential Revision: D116960011 fbshipit-source-id: 8c80d41a84fb0261baabb56ac173d77e38c9c692
1 parent a8e38da commit 0848cfb

5 files changed

Lines changed: 24 additions & 28 deletions

packages/django_workload/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ can achieve.
1919
- **Thrift RPC Backend**: Mock Thrift servers provide realistic backend service calls
2020
- **Dynamic Load Generation**: wrk-based load generator with entity ID tracking for
2121
realistic /seen requests
22-
- **JIT Support**: Cinder JIT compilation support for x86 platforms
22+
- **JIT Support**: Cinder JIT compilation support for x86 and AArch64 platforms
2323
- **Dual Interpreter Support**: Choose between CPython and Cinder interpreters
2424

2525
For more details about DjangoBench V2's software architecture, please refer to
@@ -129,7 +129,7 @@ To specify which interpreter to use, add the `interpreter` parameter to your com
129129
When running with a separate database server:
130130

131131
```
132-
# Run with Cinder and JIT (default for x86)
132+
# Run with Cinder and JIT (default)
133133
./benchpress_cli.py run django_workload_default -r clientserver -i '{"db_addr": "<db-server-ip>"}'
134134
135135
# Run with CPython
@@ -247,11 +247,11 @@ For `django_workload_default`:
247247
a fixed duration. Unlike the behavior of Siege, now the total number of requests that wrk will send
248248
will be `reps`, _not_ `reps * iterations`.
249249
* `interpreter` \- Which python interpreter to use: choose between `cpython` or `cinder`.
250-
Defaults to `cinder` for x86 jobs, `cpython` for ARM jobs.
250+
Defaults to `cinder` for `django_workload_default` on x86 and ARM.
251251
* `use_async` \- If this is set to 1, DjangoBench will use the asynchronous server stack with
252252
load balancing; set to 0 means using the traditional stack. Defaults to 1.
253-
* `use_jit` \- If this is set to a positive number, enables Cinder JIT (x86 only).
254-
Defaults to 1 for x86 jobs, 0 for ARM jobs.
253+
* `use_jit` \- If this is set to a positive number, enables Cinder JIT.
254+
Defaults to 1 for `django_workload_default` on x86 and ARM.
255255
* `base_port` \- Starting port that the HTTP server workers will listen to.
256256
The range of `[base_port, base_port + nproc)` must be available. Defaults to 16668.
257257
* `stats_port` \- Load balancer stats port. Defaults to 8001.
@@ -455,7 +455,7 @@ If you encounter issues with the Thrift RPC servers:
455455

456456
### Cinder-specific issues
457457

458-
**Note**: Cinder JIT is only supported on x86 platforms. It will not work on ARM.
458+
**Note**: Cinder JIT is supported on both x86 and AArch64 platforms.
459459

460460
If you encounter issues when running with the Cinder interpreter:
461461

packages/django_workload/install_django_workload_aarch64.sh

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ echo "JDK installed successfully"
184184
# Install Cassandra
185185
# Download Cassandra from third-party source
186186
if [ "$VERSION_ID" -ge 10 ]; then
187-
cassandra_version=5.0.8
187+
cassandra_version=5.0.9
188188
else
189189
cassandra_version=3.11.19
190190
fi
@@ -286,11 +286,10 @@ echo "====================================================================="
286286
echo "Step 5: Building Cinder 3.14"
287287
echo "====================================================================="
288288

289-
# Download and build Cinder
290-
# Using meta/3.14 branch — includes gh-145615 mimalloc page leak fix
291-
CINDER_COMMIT="7627b90844073b94ef60415ed1f1248837bedef7"
289+
# Download and build MetaPython
290+
CINDER_COMMIT="81b5092b60e86d7ce588bc80028f117d0415b230"
292291
if ! [ -d "cinder" ]; then
293-
git clone https://github.com/facebookincubator/cinder.git
292+
git clone https://github.com/facebookincubator/MetaPython.git cinder
294293
pushd cinder
295294
git checkout "${CINDER_COMMIT}"
296295
mkdir -p cinder-build
@@ -479,7 +478,7 @@ echo "Step 6.5: Installing CinderX for JIT Support"
479478
echo "====================================================================="
480479

481480
# Clone and install CinderX for JIT functionality
482-
CINDERX_COMMIT="6e0472215c9917c2b5c9777dd4702b5d84eb3111"
481+
CINDERX_COMMIT="5ffa367bb41a12d452eab9d7017fe324a6a5f090"
483482
if ! [ -d "${DJANGO_SERVER_ROOT}/cinderx" ]; then
484483
cd "${DJANGO_SERVER_ROOT}"
485484
git clone https://github.com/facebookincubator/cinderx.git

packages/django_workload/install_django_workload_aarch64_ubuntu22_24.sh

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -319,11 +319,10 @@ echo "====================================================================="
319319
echo "Step 5: Building Cinder 3.14"
320320
echo "====================================================================="
321321

322-
# Download and build Cinder
323-
# Using meta/3.14 branch at a known good commit for reproducibility
324-
CINDER_COMMIT="04f91c3659d8d2dfe4331a47548316289d2fa3f0"
322+
# Download and build MetaPython
323+
CINDER_COMMIT="81b5092b60e86d7ce588bc80028f117d0415b230"
325324
if ! [ -d "cinder" ]; then
326-
git clone https://github.com/facebookincubator/cinder.git
325+
git clone https://github.com/facebookincubator/MetaPython.git cinder
327326
pushd cinder
328327
git checkout "${CINDER_COMMIT}"
329328
mkdir -p cinder-build
@@ -514,7 +513,7 @@ echo "Step 6.5: Installing CinderX for JIT Support"
514513
echo "====================================================================="
515514

516515
# Clone and install CinderX for JIT functionality
517-
CINDERX_COMMIT="497b2b671a8084345a8288cfbd9995acfab9dfbf"
516+
CINDERX_COMMIT="5ffa367bb41a12d452eab9d7017fe324a6a5f090"
518517
if ! [ -d "${DJANGO_SERVER_ROOT}/cinderx" ]; then
519518
cd "${DJANGO_SERVER_ROOT}"
520519
git clone https://github.com/facebookincubator/cinderx.git

packages/django_workload/install_django_workload_x86_64_centos.sh

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ echo "JDK installed successfully"
194194
# Install Cassandra
195195
# Download Cassandra from third-party source
196196
if [ "$VERSION_ID" -ge 10 ]; then
197-
cassandra_version=5.0.8
197+
cassandra_version=5.0.9
198198
else
199199
cassandra_version=3.11.19
200200
fi
@@ -305,15 +305,14 @@ echo "====================================================================="
305305
echo "Step 5: Building Cinder 3.14"
306306
echo "====================================================================="
307307

308-
# Download and build Cinder
309-
# Using meta/3.14 branch — includes gh-145615 mimalloc page leak fix
310-
CINDER_COMMIT="7627b90844073b94ef60415ed1f1248837bedef7"
308+
# Download and build MetaPython
309+
CINDER_COMMIT="81b5092b60e86d7ce588bc80028f117d0415b230"
311310
if ! [ -d "cinder" ]; then
312311
dnf reinstall -y zlib-devel || dnf install -y zlib-ng-compat-devel || dnf install -y zlib-devel
313312
if [ ! -e /usr/lib64/libz.so ] && [ -e /usr/lib64/libz.so.1 ]; then
314313
ln -sf /usr/lib64/libz.so.1 /usr/lib64/libz.so
315314
fi
316-
git clone https://github.com/facebookincubator/cinder.git
315+
git clone https://github.com/facebookincubator/MetaPython.git cinder
317316
pushd cinder
318317
git checkout "${CINDER_COMMIT}"
319318
mkdir -p cinder-build
@@ -501,7 +500,7 @@ echo "Step 6.5: Installing CinderX for JIT Support"
501500
echo "====================================================================="
502501

503502
# Clone and install CinderX for JIT functionality
504-
CINDERX_COMMIT="6e0472215c9917c2b5c9777dd4702b5d84eb3111"
503+
CINDERX_COMMIT="5ffa367bb41a12d452eab9d7017fe324a6a5f090"
505504
if ! [ -d "${DJANGO_SERVER_ROOT}/cinderx" ]; then
506505
cd "${DJANGO_SERVER_ROOT}"
507506
git clone https://github.com/facebookincubator/cinderx.git

packages/django_workload/install_django_workload_x86_64_ubuntu22_24.sh

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -321,11 +321,10 @@ echo "====================================================================="
321321
echo "Step 5: Building Cinder 3.14"
322322
echo "====================================================================="
323323

324-
# Download and build Cinder
325-
# Using meta/3.14 branch at a known good commit for reproducibility
326-
CINDER_COMMIT="04f91c3659d8d2dfe4331a47548316289d2fa3f0"
324+
# Download and build MetaPython
325+
CINDER_COMMIT="81b5092b60e86d7ce588bc80028f117d0415b230"
327326
if ! [ -d "cinder" ]; then
328-
git clone https://github.com/facebookincubator/cinder.git
327+
git clone https://github.com/facebookincubator/MetaPython.git cinder
329328
pushd cinder
330329
git checkout "${CINDER_COMMIT}"
331330
mkdir -p cinder-build
@@ -516,7 +515,7 @@ echo "Step 6.5: Installing CinderX for JIT Support"
516515
echo "====================================================================="
517516

518517
# Clone and install CinderX for JIT functionality
519-
CINDERX_COMMIT="497b2b671a8084345a8288cfbd9995acfab9dfbf"
518+
CINDERX_COMMIT="5ffa367bb41a12d452eab9d7017fe324a6a5f090"
520519
if ! [ -d "${DJANGO_SERVER_ROOT}/cinderx" ]; then
521520
cd "${DJANGO_SERVER_ROOT}"
522521
git clone https://github.com/facebookincubator/cinderx.git

0 commit comments

Comments
 (0)