Skip to content

Commit 2e08c9a

Browse files
Fbgemm embedding (#238)
Summary: Two patches to fix FBGEMM git clone failures and runtime errors: The FBGEMM_VERSION=fd32631d837b41251311099c393af7d7be5cfbf variable points to a commit ID. Using it with git clone -b $FBGEMM_VERSION fails. This patch corrects that issue. The fbgemm_embedding benchmarks are now run through run.sh, so the benchmark execution script has been updated accordingly. Pull Request resolved: #238 Reviewed By: excelle08 Differential Revision: D83988062 Pulled By: YifanYuan3 fbshipit-source-id: df7bdcb385a67de65dff66cfa3cee535565fb867
1 parent 45f88de commit 2e08c9a

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

benchpress/config/jobs_ai.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
name: fbgemm_embedding_a_single
1515
description: Performance benchmark for Model A workload using one single representative embedding table.
1616
args:
17+
- tbe_inference_benchmark
1718
- nbit-cpu
1819
- '--num-embeddings={embeddings}'
1920
- '--bag-size={bag_size}'
@@ -40,6 +41,7 @@
4041
name: fbgemm_embedding_a_spec
4142
description: Performance benchmark for Model A workload using a representative set of embedding tables with different bag sizes.
4243
args:
44+
- tbe_inference_benchmark
4345
- nbit-device-with-spec
4446
- '--num-embeddings-list={embeddings_list}'
4547
- '--bag-size-list={bag_size_list}'
@@ -66,6 +68,7 @@
6668
name: fbgemm_embedding_b_spec_int4
6769
description: Performance benchmark for Model B workload using a representative set of embedding tables with int4 precision.
6870
args:
71+
- tbe_inference_benchmark
6972
- nbit-device-with-spec
7073
- '--num-embeddings-list={embeddings_list}'
7174
- '--bag-size-list={bag_size_list}'
@@ -92,6 +95,7 @@
9295
name: fbgemm_embedding_b_spec_int8
9396
description: Performance benchmark for Model B workload using a representative set of embedding tables with int8 precision.
9497
args:
98+
- tbe_inference_benchmark
9599
- nbit-device-with-spec
96100
- '--num-embeddings-list={embeddings_list}'
97101
- '--bag-size-list={bag_size_list}'

packages/fbgemm/install_fbgemm_bench.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -904,7 +904,8 @@ clone_fbgemm_repo() {
904904
# Clone the FBGEMM repository along with its submodules
905905
# We specify the version tag to ensure we get the correct version
906906
echo "[SETUP] Cloning repository with submodules..."
907-
git clone --recursive -b ${FBGEMM_VERSION} https://github.com/pytorch/FBGEMM.git fbgemm_${FBGEMM_VERSION}
907+
git clone --recursive https://github.com/pytorch/FBGEMM.git fbgemm_${FBGEMM_VERSION}
908+
git -C fbgemm_${FBGEMM_VERSION} checkout ${FBGEMM_VERSION}
908909

909910
# Disable the postbuild script to prevent race conditions during linking
910911
# This is a workaround for a known issue in the build process

0 commit comments

Comments
 (0)