Skip to content

Commit db43609

Browse files
ahmadelyousseffacebook-github-bot
authored andcommitted
Fix DCPerf v1 benchmarks: CI tests, install markers, and feedsim build fixes
Differential Revision: D113329464
1 parent 2884985 commit db43609

2 files changed

Lines changed: 32 additions & 0 deletions

File tree

benchpress/config/__init__.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929

3030
import importlib.resources
3131
import logging
32+
import os
3233
from contextlib import AbstractContextManager
3334
from pathlib import Path
3435
from typing import IO, Iterator, Union
@@ -66,8 +67,17 @@ def register_benchmark_suite(name):
6667
)
6768

6869

70+
# The v1/wdl_v1 suites depend on internal-only resources, so they are hidden
71+
# from true open-source builds. They must also be available when running the
72+
# internal checkout directly (e.g. the benchpress_v1.sky CI workflow, which
73+
# runs `python3 benchpress_cli.py` from the source tree where is_opensource is
74+
# still True); that path sets IS_INTERNAL_TEST=1, so key off it as well.
75+
_enable_internal_suites = (not open_source) or os.environ.get("IS_INTERNAL_TEST") == "1"
76+
6977
if not open_source:
7078
register_benchmark_suite("internal")
79+
80+
if _enable_internal_suites:
7181
register_benchmark_suite("wdl_v1")
7282
register_benchmark_suite("v1")
7383

benchpress/config/benchmarks_wdl.yml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,28 @@ wdl_bench:
77
parser: wdl_bench
88
install_script: ./packages/wdl_bench/install_wdl_bench.sh
99
cleanup_script: ./packages/wdl_bench/cleanup_wdl_bench.sh
10+
install_markers:
11+
- ./benchmarks/wdl_bench/ProtocolBench
12+
- ./benchmarks/wdl_bench/VarintUtilsBench
13+
- ./benchmarks/wdl_bench/bench-memcmp
14+
- ./benchmarks/wdl_bench/benchsleef128
15+
- ./benchmarks/wdl_bench/concurrency_concurrent_hash_map_bench
16+
- ./benchmarks/wdl_bench/container_hash_maps_bench
17+
- ./benchmarks/wdl_bench/erasure_code_perf
18+
- ./benchmarks/wdl_bench/hash_checksum_benchmark
19+
- ./benchmarks/wdl_bench/hash_hash_benchmark
20+
- ./benchmarks/wdl_bench/libaegis_benchmark
21+
- ./benchmarks/wdl_bench/lzbench
22+
- ./benchmarks/wdl_bench/memcpy_benchmark
23+
- ./benchmarks/wdl_bench/memset_benchmark
24+
- ./benchmarks/wdl_bench/openssl
25+
- ./benchmarks/wdl_bench/random_benchmark
26+
- ./benchmarks/wdl_bench/stdcpp_bench
27+
- ./benchmarks/wdl_bench/synchronization_lifo_sem_bench
28+
- ./benchmarks/wdl_bench/synchronization_small_locks_benchmark
29+
- ./benchmarks/wdl_bench/vdso_bench
30+
- ./benchmarks/wdl_bench/xxhash_benchmark
31+
- ./benchmarks/wdl_bench/run.sh
1032
path: ./benchmarks/wdl_bench/run.sh
1133
tags:
1234
scope:

0 commit comments

Comments
 (0)