Fix unsafe fallthrough at fbcode/fbpcf/scheduler/gate_keeper/BatchCompositeGate.h:63 (#533)

Zhenhuan Zhang · facebook-github-bot · commit 76ee6a90a8b0 · 2024-02-21T15:56:13.000-08:00
Summary: Pull Request resolved: #533 details in T179856888 **context** LLVM has detected an implicit fallthrough near fbcode/fbpcf/scheduler/gate_keeper/BatchCompositeGate.h:63. Implicit fallthroughs have a very high bug rate, so we are making them a compiler error by default. Reviewed By: ztlbells Differential Revision: D54025656 fbshipit-source-id: 4a2c501c17063b2bb0a91489df169544b59ab75f
diff --git a/fbpcf/scheduler/gate_keeper/BatchCompositeGate.h b/fbpcf/scheduler/gate_keeper/BatchCompositeGate.h
@@ -58,6 +58,7 @@ class BatchCompositeGate final : public ICompositeGate {
               engine.computeBatchFreeAND(
                   leftValues, wireKeeper_.getBatchBooleanValue(rights_[i])));
         }
+        break;
       }
 
       case GateType::NonFreeAnd: {

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ class BatchCompositeGate final : public ICompositeGate {`
`58`	`58`	`engine.computeBatchFreeAND(`
`59`	`59`	`leftValues, wireKeeper_.getBatchBooleanValue(rights_[i])));`
`60`	`60`	`}`
	`61`	`+ break;`
`61`	`62`	`}`
`62`	`63`
`63`	`64`	`case GateType::NonFreeAnd: {`