Remove unused type error suppressions - fair_infra

Summary:
This diff was automatically generated by the Pyre per-target upgrade tool.

It removes `# pyre-fixme` or `pyrefly: ignore` comments that are no longer needed because the underlying type errors have been resolved.
Note that it will also aim to ensure type checking runs cleanly, and will add suppressions to existing type errors.

#pyreupgrade

Differential Revision: D116359364

fbshipit-source-id: 57c47ce4ca6a5a617c684220b1b0e195bb1af048

Author: generatedunixname89002005307016

iopath/common/azure_blob.py

@@ -101,7 +101,6 @@ def _next_chunk(self) -> None:
         logger.info(
             "Read next chunk: blob_name=%s, length=%d",
             blob_name,
-            # pyre-ignore[6]
             len(self._chunk),
         )
         self._chunk_pos = 0
@@ -257,7 +256,6 @@ def flush(self) -> None:
         assert self._chunk is not None
 
         block_id = self._new_block_id()
-        # pyre-ignore[16]
         block_length = self._chunk.tell()
         # pyre-ignore[16]
         self._chunk.seek(0)

iopath/common/event_logger.py

@@ -38,11 +38,8 @@ class EventLogger:
     # pyre-fixme[2]: Parameter must be annotated.
     def __init__(self, *args, **kwargs):
         if b_tmetry_available:
-            # pyre-fixme[4]: Attribute must be annotated.
             self._writers = []
-            # pyre-fixme[4]: Attribute must be annotated.
             self._evt = SimpleEventRecord()
-            # pyre-fixme[4]: Attribute must be annotated.
             self._enabled = True
 
     # pyre-fixme[3]: Return type must be annotated.

iopath/common/file_io.py

@@ -127,7 +127,7 @@ def __init__(self, func: Callable[[], str]) -> None:
     def _get_value(self) -> str:
         if self._value is None:
             self._value = self._func()
-        return self._value  # pyre-ignore
+        return self._value
 
     def __fspath__(self) -> str:
         return self._get_value()
@@ -1080,7 +1080,7 @@ def get_path_handler(self, path: Union[str, os.PathLike]) -> PathHandler:
         Returns:
             handler (PathHandler)
         """
-        path = os.fspath(path)  # pyre-ignore
+        path = os.fspath(path)
         for p, handler in self._path_handlers.items():
             if path.startswith(p):
                 return handler
@@ -1108,7 +1108,6 @@ def __log_tmetry_keys(self, handler: PathHandler, kvs: Dict[str, VTYPE]) -> None
                 )
                 self._enable_logging = False
 
-    # pyre-fixme[34]: `Variable[VTYPE <: [str, int, bool, float]]` isn't present in
     #  the function's parameters.
     def __get_open_keys(self, path: str, mode: str, buffering: int) -> Dict[str, VTYPE]:
         """
@@ -1178,7 +1177,6 @@ def openw(
     def open(
         self,
         path: str,
-        # pyrefly: ignore [unsupported-operation]
         mode: Literal["rb", "wb", "ab", "xb", "r+b", "w+b", "a+b", "x+b"] = ...,
         buffering: int = ...,
         **kwargs: Any,
@@ -1188,7 +1186,6 @@ def open(
     def open(
         self,
         path: str,
-        # pyrefly: ignore [unsupported-operation]
         mode: Literal["r", "w", "a", "x", "r+", "w+", "a+", "x+", "rt", "wt"] = ...,
         buffering: int = ...,
         **kwargs: Any,

iopath/common/non_blocking_io.py

@@ -63,11 +63,9 @@ def __init__(
             executor: User can optionally attach a custom executor to
                 perform async operations through `PathHandler.__init__`.
         """
-        # pyre-fixme[4]: Attribute must be annotated.
         self._path_to_data = {}  # Map from path to `PathData` object
         self._buffered = buffered
         self._IO = NonBlockingBufferedIO if self._buffered else NonBlockingIO
-        # pyre-fixme[4]: Attribute must be annotated.
         self._pool = executor or concurrent.futures.ThreadPoolExecutor()
 
     def get_non_blocking_io(
@@ -110,7 +108,6 @@ def get_non_blocking_io(
             self._path_to_data[path] = PathData(queue, t)
 
         kwargs = {} if not self._buffered else {"buffering": buffering}
-        # pyre-fixme[29]: `Type[Union[NonBlockingBufferedIO, NonBlockingIO]]` is not
         #  a function.
         return self._IO(
             notify_manager=lambda io_callable: (  # Pass async jobs to manager
@@ -296,7 +293,6 @@ def close(self) -> None:
 # NOTE: To use this class, use `buffered=True` in `NonBlockingIOManager`.
 # NOTE: This class expects the IO mode to be buffered.
 class NonBlockingBufferedIO(io.IOBase):
-    # pyre-fixme[4]: Attribute must be annotated.
     MAX_BUFFER_BYTES = 10 * 1024 * 1024  # 10 MiB
 
     def __init__(
@@ -321,7 +317,6 @@ def __init__(
         self._callback_after_file_close = callback_after_file_close
 
         self._buffers = [io.BytesIO()]
-        # pyre-fixme[4]: Attribute must be annotated.
         self._buffer_size = buffering if buffering > 0 else self.MAX_BUFFER_BYTES
         self._close_called = False
 

iopath/common/s3.py

@@ -113,9 +113,7 @@ def __init__(
         # pyre-fixme[21]: Could not find module `boto3.s3.transfer`.
         from boto3.s3.transfer import TransferConfig
 
-        # pyre-fixme[4]: Attribute must be annotated.
         self.transfer_config = TransferConfig(
-            # pyrefly: ignore [bad-argument-type]
             **(transfer_config_kwargs if transfer_config_kwargs else {})
         )
 
@@ -639,7 +637,6 @@ def _rm(self, path: str, **kwargs: Any) -> None:
 
 
 class S3ChunkReadIO(io.BufferedIOBase):
-    # pyre-fixme[4]: Attribute must be annotated.
     DEFAULT_CHUNK_SIZE = 50 * 1024 * 1024  # 50MB
 
     # pyre-fixme[3]: Return type must be annotated.
@@ -656,7 +653,6 @@ def __init__(
         self.client = client
         self.bucket = bucket
         self.key = key
-        # pyre-fixme[4]: Attribute must be annotated.
         self.timeout = timeout.total_seconds() if timeout is not None else None
         self.chunk_size = chunk_size
         self.offset = 0

tests/async_writes_test.py

@@ -16,7 +16,6 @@
 from iopath.common.file_io import PathManager
 
 
-# pyre-fixme[5]: Global expression must be annotated.
 logger = logging.getLogger(__name__)
 
 

tests/test_download.py

@@ -11,7 +11,6 @@
 
 
 class TestDownload(unittest.TestCase):
-    # pyre-fixme[4]: Attribute must be annotated.
     _filename = "facebook_" + uuid.uuid4().hex + ".html"
 
     # pyre-fixme[3]: Return type must be annotated.

tests/test_file_io.py

@@ -412,7 +412,6 @@ def test_open_writes(self) -> None:
         # HTTPURLHandler does not support writing, only reading.
         with self.assertRaises(AssertionError):
             with self._pathmgr.open(self._remote_uri, "w") as f:
-                # pyrefly: ignore [no-matching-overload]
                 f.write("foobar")
 
     def test_open_new_path_manager(self) -> None: