Commit acc421e
Remaining fixes to unblock nightly build (#504)
Summary:
Two more changes to fix our nightly builds:
1) Add \_\_init\_\_.py to `torchmultimodal/models/video_gpt/` to fix import failures.
2) Define a new test util to skip unit tests if ffmpeg is not installed. Per discussions with mthrok torchaudio does not come with ffmpeg installed, though when we use conda install it will be included with torchvision. As a result, the pip install command in our nightly builds does not have ffmpeg, which causes some of our audio MAE transform tests to fail. We also do not want to install it directly with our library due to licensing. As a result, we add a test utility to skip these tests if ffmpeg is not installed.
Pull Request resolved: #504
Test Plan:
Create a new conda env and follow the steps in nightly_build.yaml to install our deps with pip (so no ffmpeg).
```
conda create -n tmm-10-24-23-no-ffmpeg python=3.8
conda activate tmm-10-24-23-no-ffmpeg
python -m pip install --pre torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/nightly/cpu
python -m pip install -r requirements.txt
python -m pip install pytest pytest-mock pytest-cov
python -m pytest -v tests/transforms
...
============ 58 passed, 7 skipped in 2.79s =========
```
Also confirmed that by removing one of the `skip_if_no_mmpeg` decorator from one of the tests in the same environment causes it to fail.
Reviewed By: rohan-varma
Differential Revision: D50613602
Pulled By: ebsmothers
fbshipit-source-id: e4d5c96911c7b2204f62318c0737c1cdfb3bd0fd1 parent 2155161 commit acc421e
3 files changed
Lines changed: 25 additions & 1 deletion
File tree
- tests
- transforms
- torchmultimodal/models/video_gpt
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
286 | 286 | | |
287 | 287 | | |
288 | 288 | | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
14 | 19 | | |
15 | 20 | | |
16 | 21 | | |
| |||
275 | 280 | | |
276 | 281 | | |
277 | 282 | | |
| 283 | + | |
278 | 284 | | |
279 | 285 | | |
280 | 286 | | |
281 | 287 | | |
282 | 288 | | |
| 289 | + | |
283 | 290 | | |
284 | 291 | | |
285 | 292 | | |
| |||
295 | 302 | | |
296 | 303 | | |
297 | 304 | | |
| 305 | + | |
298 | 306 | | |
299 | 307 | | |
300 | 308 | | |
301 | 309 | | |
302 | 310 | | |
| 311 | + | |
303 | 312 | | |
304 | 313 | | |
305 | 314 | | |
| |||
316 | 325 | | |
317 | 326 | | |
318 | 327 | | |
| 328 | + | |
319 | 329 | | |
320 | 330 | | |
321 | 331 | | |
322 | 332 | | |
323 | 333 | | |
| 334 | + | |
324 | 335 | | |
325 | 336 | | |
326 | 337 | | |
327 | 338 | | |
328 | 339 | | |
| 340 | + | |
329 | 341 | | |
330 | 342 | | |
331 | 343 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
0 commit comments