refactor: Reorganize folders and files (#2145)

Co-authored-by: Claude <noreply@anthropic.com>

Author: DaveSkender

.agents/skills/code-completion/SKILL.md

@@ -83,9 +83,9 @@ Do not ignore, defer, or suppress warnings.
 
 New or updated indicators require:
 
-- Series: `*.StaticSeries.cs`
+- Series: `{Indicator}.Series.cs` partial class file
 - Catalog: `*.Catalog.cs` + registration
-- Tests: `*.Tests.cs` with full coverage
+- Tests: `*Tests.cs` with full coverage
 - Docs: `docs/indicators/{Name}.md`
 - Regression baseline (if algorithm changed)
 - Performance benchmark (complex indicators)

.agents/skills/indicator-buffer/SKILL.md

@@ -76,17 +76,17 @@ public override void Clear()
 
 ## Required implementation
 
-- [ ] Source code: `src/**/{IndicatorName}.BufferList.cs` file exists
+- [ ] Source code: `src/**/{IndicatorName}List.cs` file exists
   - [ ] Inherits `BufferList<TResult>` and implements correct increment interface
   - [ ] Two constructors: primary + chaining via `: this(...) => Add(...);`
   - [ ] Uses `BufferListUtilities.Update()` or `UpdateWithDequeue()`
   - [ ] `Clear()` resets results and all internal buffers
-- [ ] Unit testing: `tests/indicators/**/{IndicatorName}.BufferList.Tests.cs` exists
+- [ ] Unit testing: `tests/Library/Indicators/**/{IndicatorName}BufferListTests.cs` exists
   - [ ] Inherits `BufferListTestBase` and implements correct test interface
   - [ ] All required abstract + interface methods implemented
   - [ ] Verifies equivalence with Series results
 - [ ] **Catalog registration**: Registered in `Catalog.Listings.cs`
 - [ ] **Performance benchmark**: Add to `tools/performance/Perf.Buffer.cs`
 - [ ] **Public documentation**: Update `docs/indicators/{IndicatorName}.md`
-- [ ] **Regression tests**: Add to `tests/indicators/**/{IndicatorName}.Regression.Tests.cs`
+- [ ] **Regression tests**: Add to `tests/Library/Indicators/**/{IndicatorName}RegressionTests.cs`
 - [ ] **Migration guide**: Update `docs/migration/v3.md` for notable and breaking changes from v2

.agents/skills/indicator-catalog/SKILL.md

@@ -7,7 +7,7 @@ description: Create and register indicator catalog entries for automation. Use f
 
 ## File
 
-`src/{category}/{Indicator}/{Indicator}.Catalog.cs`
+`src/Indicators/{category}/{Indicator}/{Indicator}.Catalog.cs`
 
 ## Builder pattern
 
@@ -131,7 +131,7 @@ listings.Add(Beta.SeriesListing);
 
 ## Testing
 
-`tests/indicators/{folder}/{Indicator}/{Indicator}.Catalog.Tests.cs`:
+`tests/Library/Indicators/{folder}/{Indicator}/{Indicator}CatalogTests.cs`:
 
 ```csharp
 [TestClass]

.agents/skills/indicator-series/SKILL.md

@@ -7,26 +7,27 @@ description: Implement Series-style batch indicators with mathematical precision
 
 ## File structure
 
-All files live in `src/{category}/{Indicator}/`:
+All files live in `src/Indicators/{category}/{Indicator}/`:
 
 | File | Purpose |
 | ---- | ------- |
-| `{Indicator}.StaticSeries.cs` | Static partial class — `To{Indicator}()` + `To{Indicator}List()` entry points |
-| `{Indicator}.StreamHub.cs` | Hub class (internal ctor) + `To{Indicator}Hub()` extension |
-| `{Indicator}.BufferList.cs` | List class + `To{Indicator}List()` extension |
+| `{Indicator}.Series.cs` | Static partial class — `To{Indicator}()` series entry point |
+| `{Indicator}Hub.cs` | Hub class (internal ctor) + `To{Indicator}Hub()` extension |
+| `{Indicator}List.cs` | List class + `To{Indicator}List()` extension |
 | `{Indicator}.Catalog.cs` | `CommonListing`, `SeriesListing`, `StreamListing`, `BufferListing` |
-| `{Indicator}.Models.cs` | Result record(s) |
+| `{Indicator}Result.cs` | Result record |
 | `{Indicator}.Utilities.cs` | `Validate()` (internal), `Increment()` (public), `RemoveWarmupPeriods()` |
 | `I{Indicator}.cs` | Parameter interface (parameter properties only; NOT result properties) |
 
-Test files mirror in `tests/indicators/{category}/{Indicator}/`:
+Test files mirror in `tests/Library/Indicators/{category}/{Indicator}/`:
 
-- `{Indicator}.StaticSeries.Tests.cs`
-- `{Indicator}.BufferList.Tests.cs`
-- `{Indicator}.StreamHub.Tests.cs`
-- `{Indicator}.Regression.Tests.cs`
+- `{Indicator}SeriesTests.cs`
+- `{Indicator}BufferListTests.cs`
+- `{Indicator}HubTests.cs`
+- `{Indicator}CatalogTests.cs`
+- `{Indicator}RegressionTests.cs`
 
-Category folders: `a-d`, `e-k`, `m-r`, `s-z` (alphabetical)
+Category folders: `a-b`, `c-d`, `e-j`, `k-q`, `r-s`, `t-z` (alphabetical)
 
 ## Performance optimization
 
@@ -42,16 +43,16 @@ Some indicators (e.g., ADL) are faster with `List.Add()` — benchmark both.
 
 ## Required implementation
 
-Beyond the `.StaticSeries.cs` file, ensure:
+Beyond the main `{Indicator}.Series.cs` file, ensure:
 
 - [ ] **Catalog registration**: Create `src/**/{Indicator}.Catalog.cs` and register in `Catalog.Listings.cs`
 - [ ] **Interface file**: Create `src/**/{Indicator}/I{Indicator}.cs` with parameter properties (NOT result properties)
-- [ ] **Unit tests**: Create `tests/indicators/**/{Indicator}.StaticSeries.Tests.cs`
+- [ ] **Unit tests**: Create `tests/Library/Indicators/**/{Indicator}SeriesTests.cs`
   - Inherit from `StaticSeriesTestBase`
   - Verify against manually calculated reference values; assert documented value ranges with `IsBetween` if applicable
 - [ ] **Performance benchmark**: Add to `tools/performance/Perf.Series.cs`
 - [ ] **Public documentation**: Update `docs/indicators/{Indicator}.md`
-- [ ] **Regression baseline tests**: Add to `tests/indicators/**/{Indicator}.Regression.Tests.cs` inheriting from `RegressionTestBase<TResult>` with `[TestCategory("Regression")]` on the class — these compare the full result set to a frozen `*.standard.json` baseline so it can be filtered via `--filter TestCategory=Regression`
+- [ ] **Regression baseline tests**: Add to `tests/Library/Indicators/**/{Indicator}RegressionTests.cs` inheriting from `RegressionTestBase<TResult>` with `[TestCategory("Regression")]` on the class — these compare the full result set to a frozen `*.standard.json` baseline so it can be filtered via `--filter TestCategory=Regression`
 - [ ] **Migration guide**: Update `docs/migration/v3.md` for notable and breaking changes from v2
 
 ## Precision testing
@@ -63,10 +64,10 @@ Beyond the `.StaticSeries.cs` file, ensure:
 
 ## Examples
 
-- Simple: `src/s-z/Sma/Sma.StaticSeries.cs`
-- Exponential smoothing: `src/e-k/Ema/Ema.StaticSeries.cs`
-- Complex multi-stage: `src/a-d/Adx/Adx.StaticSeries.cs`
-- Multi-value results: `src/a-d/Alligator/Alligator.StaticSeries.cs`
+- Simple: `src/Indicators/r-s/Sma/Sma.Series.cs`
+- Exponential smoothing: `src/Indicators/e-j/Ema/Ema.Series.cs`
+- Complex multi-stage: `src/Indicators/a-b/Adx/Adx.Series.cs`
+- Multi-value results: `src/Indicators/a-b/Alligator/Alligator.Series.cs`
 
 See [references/decision-tree.md](references/decision-tree.md) for result interface selection.
 

.agents/skills/indicator-stream/SKILL.md

@@ -97,20 +97,20 @@ Replay up to `restoreIndex` (inclusive). The item at the rollback timestamp is r
 
 ## Required implementation
 
-- [ ] Source code: `src/**/{IndicatorName}.StreamHub.cs` file exists
+- [ ] Source code: `src/**/{IndicatorName}Hub.cs` file exists
   - [ ] Uses appropriate provider base (ChainHub or BarProvider)
   - [ ] Validates parameters in constructor; calls Reinitialize() as needed
   - [ ] Implements O(1) state updates; avoids O(n²) recalculation
   - [ ] Overrides RollbackState() when maintaining stateful fields
   - [ ] Overrides ToString() with concise hub name
-- [ ] Unit testing: `tests/indicators/**/{IndicatorName}.StreamHub.Tests.cs` exists
+- [ ] Unit testing: `tests/Library/Indicators/**/{IndicatorName}HubTests.cs` exists
   - [ ] Inherits StreamHubTestBase with correct test interfaces
   - [ ] Comprehensive rollback validation present
   - [ ] Verifies Series parity
 - [ ] **Catalog registration**: Registered in `Catalog.Listings.cs`
 - [ ] **Performance benchmark**: Add to `tools/performance/Perf.Stream.cs`
 - [ ] **Public documentation**: Update `docs/indicators/{IndicatorName}.md`
-- [ ] **Regression tests**: Add to `tests/indicators/**/{IndicatorName}.Regression.Tests.cs`
+- [ ] **Regression tests**: Add to `tests/Library/Indicators/**/{IndicatorName}RegressionTests.cs`
 - [ ] **Migration guide**: Update `docs/migration/v3.md` for notable and breaking changes from v2
 
 ## References

.agents/skills/indicator-stream/references/compound-hubs.md

@@ -215,4 +215,4 @@ Follow standard StreamHub testing requirements:
 3. Test rollback validation if RollbackState is overridden
 4. Verify Series parity with the compound indicator
 
-**Example**: `tests/indicators/s-z/StochRsi/StochRsi.StreamHub.Tests.cs`
+**Example**: `tests/Library/Indicators/r-s/StochRsi/StochRsiHubTests.cs`

.coderabbit.yaml

@@ -29,8 +29,8 @@ reviews:
     - "!docs/.vitepress/dist/"   # VitePress build output
     - "!bin/"                # .NET build output
     - "!obj/"                # .NET build intermediate files
-    - "!**/_testdata/**/*.csv"   # Test data
-    - "!**/_testdata/**/*.json"  # Test data
+    - "!**/TestData/**/*.csv"   # Test data
+    - "!**/TestData/**/*.json"  # Test data
     - "!**/*.g.cs"           # Generated source code
     - "!**/*.docx"           # Office Word
     - "!**/*.pptx"           # Office PowerPoint

.editorconfig

@@ -75,11 +75,13 @@ dotnet_style_require_accessibility_modifiers = for_non_interface_members:warning
 dotnet_style_space_around_colon_in_named_argument = true:suggestion
 dotnet_diagnostic.IDE0040.severity = suggestion
 
+# Allow singular 'using' directive
+dotnet_style_namespace_match_folder = false:none
+
 # Expression-level preferences
 dotnet_style_coalesce_expression = true:suggestion
 dotnet_style_collection_initializer = true:suggestion
 dotnet_style_explicit_tuple_names = true:suggestion
-dotnet_style_namespace_match_folder = false:none
 dotnet_style_null_propagation = true:suggestion
 dotnet_style_object_initializer = true:suggestion
 dotnet_style_prefer_auto_properties = true:suggestion
@@ -181,18 +183,18 @@ csharp_prefer_static_local_function = true:suggestion
 
 # Namespace and method preferences
 csharp_style_namespace_declarations = file_scoped:suggestion
-csharp_style_prefer_method_group_conversion = true:silent
-csharp_style_prefer_top_level_statements = true:silent
+csharp_style_prefer_method_group_conversion = true:suggestion
+csharp_style_prefer_top_level_statements = true:suggestion
 csharp_style_prefer_primary_constructors = true:suggestion
 
 # Expression-bodied members
-csharp_style_expression_bodied_constructors = true:silent
-csharp_style_expression_bodied_methods = true:silent
-csharp_style_expression_bodied_operators = true:silent
-csharp_style_expression_bodied_properties = true:silent
-csharp_style_expression_bodied_indexers = true:silent
-csharp_style_expression_bodied_accessors = true:silent
-csharp_style_expression_bodied_lambdas = true:silent
+csharp_style_expression_bodied_constructors = true:suggestion
+csharp_style_expression_bodied_methods = true:suggestion
+csharp_style_expression_bodied_operators = true:suggestion
+csharp_style_expression_bodied_properties = true:suggestion
+csharp_style_expression_bodied_indexers = true:suggestion
+csharp_style_expression_bodied_accessors = true:suggestion
+csharp_style_expression_bodied_lambdas = true:suggestion
 
 # Function preferences
 csharp_style_prefer_local_over_anonymous_function = true:suggestion

.github/workflows/ci.yml

@@ -65,7 +65,7 @@ jobs:
 
       - name: Build (package tests)
         run: >
-          dotnet build tests/indicators/Tests.Indicators.csproj
+          dotnet build tests/Library/Tests.Indicators.csproj
           --configuration Release
           --property:ContinuousIntegrationBuild=true
           -warnAsError
@@ -89,7 +89,7 @@ jobs:
 
       - name: Test indicators
         run: >
-          dotnet test tests/indicators/Tests.Indicators.csproj
+          dotnet test tests/Library/Tests.Indicators.csproj
           --configuration Release
           --settings tests/tests.unit.runsettings
           --results-directory ./test-results/unit
@@ -182,7 +182,7 @@ jobs:
 
       - name: Test regression baselines
         run: >
-          dotnet test tests/indicators/Tests.Indicators.csproj
+          dotnet test tests/Library/Tests.Indicators.csproj
           --configuration Release
           --settings tests/tests.regression.runsettings
           --results-directory ./test-results/regression

.github/workflows/test-integration.yml

@@ -6,12 +6,12 @@ on:
       - "main"
       - "v[0-9]*"
     paths:
-      - "tests/integration/**"
+      - "tests/Integration/**"
       - "tools/sse-server/**"
       - ".github/workflows/test-integration.yml"
   pull_request:
     paths:
-      - "tests/integration/**"
+      - "tests/Integration/**"
       - "tools/sse-server/**"
       - ".github/workflows/test-integration.yml"
     types: [opened, synchronize, reopened, ready_for_review]