Skip to content

Commit 5ba876e

Browse files
Release Foxglove extension as installable .foxe again
The release workflow's build-foxglove job had been zipping the raw dist/ folder into cloudini-foxglove-<version>.zip, which is not an installable Foxglove extension. Use the existing `npm run package` script so CI emits a proper .foxe (via foxglove-extension package) and attach that to releases. Also fix the foxglove extension build, which was broken by the typescript 6.0.3 bump: silence the now-fatal moduleResolution deprecation and give new Uint8Array an explicit length argument. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 4123a25 commit 5ba876e

3 files changed

Lines changed: 7 additions & 11 deletions

File tree

.github/workflows/release-appimage.yaml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -154,20 +154,15 @@ jobs:
154154
working-directory: cloudini_foxglove
155155
run: npm ci
156156

157-
- name: Build Foxglove extension
157+
- name: Package Foxglove extension (.foxe)
158158
working-directory: cloudini_foxglove
159-
run: npm run build
160-
161-
- name: Package Foxglove extension
162-
run: |
163-
cd cloudini_foxglove/dist
164-
zip -r ../../cloudini-foxglove-${{ steps.get_version.outputs.VERSION }}.zip .
159+
run: npm run package
165160

166161
- name: Upload Foxglove artifact
167162
uses: actions/upload-artifact@v7
168163
with:
169164
name: foxglove-artifact
170-
path: cloudini-foxglove-*.zip
165+
path: cloudini_foxglove/release/*.foxe
171166

172167
create-release:
173168
needs: [build-appimage, build-wasm, build-foxglove]
@@ -194,6 +189,6 @@ jobs:
194189
files: |
195190
appimage-artifact/cloudini_rosbag_converter-*.AppImage
196191
wasm-artifact/cloudini-wasm-*.zip
197-
foxglove-artifact/cloudini-foxglove-*.zip
192+
foxglove-artifact/*.foxe
198193
draft: false
199194
prerelease: false

cloudini_foxglove/src/PointCloudConverter.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export const convertPointCloudWasm = (cloud: CompressedPointCloud): PointCloud =
3333
point_step: cloud.point_step,
3434
row_step: cloud.point_step * cloud.width,
3535
is_dense: cloud.is_dense,
36-
data: new Uint8Array(),
36+
data: new Uint8Array(0),
3737
};
3838

3939
// Nothing to do, the point cloud is empty

cloudini_foxglove/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
"esModuleInterop": true,
2929
"resolveJsonModule": true,
3030
"module": "esnext",
31-
"moduleResolution": "node"
31+
"moduleResolution": "node",
32+
"ignoreDeprecations": "6.0"
3233
}
3334
}

0 commit comments

Comments
 (0)