fix(app-studio): unlock infra + repo MCP tools for instance/git turns (#370)

* fix(app-studio): load infra MCP tools for instance/platform turns

The assistant only fetches the aggregated infrastructure MCP tools when
the last user message matches a keyword gate
(projectAssistantTurnNeedsInfrastructureMCP). The list covered
template/provisioning vocabulary but omitted the instance lifecycle, so
prompts like "list instances via mcp" never loaded
infrastructure__list_instances and the model truthfully replied it had
no instance list available.

Add instance/instances, platform, and mcp to the keyword list and a test
asserting the gate trips on instance/platform/mcp phrasing.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(app-studio): classify git/PR turns as implementation

Repo-mutating turns ("push my changes", "open a pull request", "merge
the branch") fell through to the discussion profile, so the commit/repo
MCP bridge was never unlocked for them. Add git, push, pull request,
branch, and merge to the implementation keyword set (skipping a bare
"pr", which is a substring of too many common words).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: mjudeikis

providers/app-studio/api/assistant_eino_tool.go

@@ -135,7 +135,9 @@ func projectAssistantTurnNeedsInfrastructureMCP(history []store.Message) bool {
 		}
 		content := strings.ToLower(strings.TrimSpace(history[i].Content))
 		return containsProjectAssistantTurnKeyword(content, []string{
-			"infrastructure", "infra", "template", "templates", "provision", "database", "postgres", "redis", "supporting resource", "provider",
+			"infrastructure", "infra", "template", "templates", "provision",
+			"instance", "instances", "database", "postgres", "redis",
+			"supporting resource", "provider", "platform", "mcp",
 		})
 	}
 	return false

providers/app-studio/api/assistant_eino_tool_test.go

@@ -22,9 +22,35 @@ import (
 	"testing"
 
 	aiv1alpha1 "github.com/faroshq/provider-app-studio/apis/ai/v1alpha1"
+	"github.com/faroshq/provider-app-studio/store"
 	"github.com/faroshq/provider-app-studio/workspace"
 )
 
+func TestProjectAssistantTurnNeedsInfrastructureMCP(t *testing.T) {
+	for _, tc := range []struct {
+		name    string
+		content string
+		want    bool
+	}{
+		{"list instances", "list instances via mcp", true},
+		{"single instance", "show me the status of my instance", true},
+		{"platform vocabulary", "what platform resources do I have?", true},
+		{"mcp mention", "call mcp to enumerate things", true},
+		{"templates", "what templates are available?", true},
+		{"unrelated", "fix the button styling in app.js", false},
+	} {
+		t.Run(tc.name, func(t *testing.T) {
+			history := []store.Message{{
+				Role:    aiv1alpha1.ProjectMessageRoleUser,
+				Content: tc.content,
+			}}
+			if got := projectAssistantTurnNeedsInfrastructureMCP(history); got != tc.want {
+				t.Fatalf("projectAssistantTurnNeedsInfrastructureMCP(%q) = %v, want %v", tc.content, got, tc.want)
+			}
+		})
+	}
+}
+
 func TestEinoApprovePlanToolRejectsMissingAllowedOperations(t *testing.T) {
 	runState := newProjectEinoAssistantRunState()
 	tool := projectEinoAssistantTool{runState: runState}

providers/app-studio/api/assistant_turn_profile.go

@@ -166,6 +166,7 @@ func fallbackProjectAssistantTurnDecisionForMessage(content string) projectAssis
 	}
 	if containsProjectAssistantTurnKeyword(normalized, []string{
 		"build", "add", "change", "update", "implement", "write", "make the app", "create", "remove", "delete", "ship", "commit", "deploy", "provision",
+		"git", "push", "pull request", "branch", "merge",
 	}) {
 		return fallbackProjectAssistantTurnDecisionWithProfile(projectAssistantTurnProfileImplementation)
 	}

providers/app-studio/api/assistant_turn_profile_test.go

@@ -43,6 +43,9 @@ func TestProjectAssistantTurnProfileClassifier(t *testing.T) {
 		{name: "debug fix", message: "Fix the failed fetch error and make it work", want: projectAssistantTurnProfileDebugFix},
 		{name: "fix only fallback", message: "Please fix the login form", want: projectAssistantTurnProfileDebugFix},
 		{name: "implementation", message: "Add a search field to the todo app", want: projectAssistantTurnProfileImplementation},
+		{name: "git push", message: "push my changes to git", want: projectAssistantTurnProfileImplementation},
+		{name: "pull request", message: "open a pull request for this branch", want: projectAssistantTurnProfileImplementation},
+		{name: "merge", message: "merge the feature branch", want: projectAssistantTurnProfileImplementation},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {