Skip to content

ci: add ci fixes - #784

Merged
nullr0ute merged 4 commits into
fdo-rs:mainfrom
mcattamoredhat:add-ci-fixes
Jul 9, 2025
Merged

ci: add ci fixes#784
nullr0ute merged 4 commits into
fdo-rs:mainfrom
mcattamoredhat:add-ci-fixes

Conversation

@mcattamoredhat

Copy link
Copy Markdown
Collaborator

This PR gathers the changes of the following PRs: #780, #781, #783

nullr0ute
nullr0ute previously approved these changes Jul 8, 2025

@nullr0ute nullr0ute left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine to me, I would like someone with a better rust knowledge than me to review the clippy fixes too

@nullr0ute

Copy link
Copy Markdown
Contributor

The new postgresql test failure looks to be something with centos stream 9 repos.

@nullr0ute

Copy link
Copy Markdown
Contributor

and looking at the labeler CI failure it appears to still not like that

Comment thread .github/labeler.yml Outdated
Comment on lines +3 to +4
- any-glob-to-any-file: "libfdo-data/fdo_data.h"
- any-glob-to-any-file: "libfdo-data/libfdo-data-go.doc"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a YAML array now; see the new syntax

Suggested change
- any-glob-to-any-file: "libfdo-data/fdo_data.h"
- any-glob-to-any-file: "libfdo-data/libfdo-data-go.doc"
- any-glob-to-any-file:
- "libfdo-data/fdo_data.h"
- "libfdo-data/libfdo-data-go.doc"

@miabbott

miabbott commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

Overall looks fine to me, I would like someone with a better rust knowledge than me to review the clippy fixes too

I'm not terribly familiar with Rust, but the changes I see were the same that I arrived at when I was tinkering on this issue.

@7flying

7flying commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

Rust part LGTM.

The postgres_test part of the CI needs to be re-launched, it should pass

@nullr0ute

Copy link
Copy Markdown
Contributor

So I think this is still failing because it's using the main branch for the config file AFAICT from a couple of tickets I had found and the Changes page. So I think this should be fine, we can always do a follow up.

@nullr0ute
nullr0ute merged commit 31b6b8a into fdo-rs:main Jul 9, 2025
53 of 58 checks passed
@nullr0ute

Copy link
Copy Markdown
Contributor

Some further details on the pull_request_target event as it runs on the base branch FYI.

@nullr0ute

Copy link
Copy Markdown
Contributor

That worked on re-running CI on another merge request 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants