ci: add ci fixes - #784
Conversation
nullr0ute
left a comment
There was a problem hiding this comment.
Overall looks fine to me, I would like someone with a better rust knowledge than me to review the clippy fixes too
|
The new postgresql test failure looks to be something with centos stream 9 repos. |
|
and looking at the labeler CI failure it appears to still not like that |
| - any-glob-to-any-file: "libfdo-data/fdo_data.h" | ||
| - any-glob-to-any-file: "libfdo-data/libfdo-data-go.doc" |
There was a problem hiding this comment.
This should be a YAML array now; see the new syntax
| - any-glob-to-any-file: "libfdo-data/fdo_data.h" | |
| - any-glob-to-any-file: "libfdo-data/libfdo-data-go.doc" | |
| - any-glob-to-any-file: | |
| - "libfdo-data/fdo_data.h" | |
| - "libfdo-data/libfdo-data-go.doc" |
I'm not terribly familiar with Rust, but the changes I see were the same that I arrived at when I was tinkering on this issue. |
|
Rust part LGTM. The postgres_test part of the CI needs to be re-launched, it should pass |
c60c77f to
a0b67b6
Compare
a0b67b6 to
d603890
Compare
|
So I think this is still failing because it's using the main branch for the config file AFAICT from a couple of tickets I had found and the Changes page. So I think this should be fine, we can always do a follow up. |
|
Some further details on the pull_request_target event as it runs on the base branch FYI. |
|
That worked on re-running CI on another merge request 👍 |
This PR gathers the changes of the following PRs: #780, #781, #783