Verify generated Astro projects on Deno

Give each Deno compatibility server a reserved port and embed that port in
the adapter configuration at build time.  Generate npm-backed dependencies
that Vite can resolve, then build generated Deno projects with local package
links exposed through node_modules.

#936 (comment)
#936 (comment)

Assisted-by: Codex:gpt-5.6-sol

Author: dahlia

docs/manual/integration.md

@@ -879,7 +879,7 @@ to integrate Fedify with Astro:
 ::: code-group
 
 ~~~~ sh [Deno]
-deno add jsr:@fedify/astro
+deno add npm:@fedify/astro
 ~~~~
 
 ~~~~ sh [npm]
@@ -957,6 +957,10 @@ export const onRequest = sequence(
 
 ### For Deno users
 
+Install packages that Astro loads through Vite from npm.  Vite resolves these
+imports through *node\_modules/* rather than Deno's JSR import map;
+`fedify init` selects npm packages for this reason.
+
 If you are using Deno, you should import `@deno/astro-adapter` in
 _astro.config.ts_ and use it as the adapter:
 

packages/astro/README.md

@@ -78,6 +78,10 @@ export const onRequest = sequence(
 For Deno users
 --------------
 
+Install `@fedify/astro` and the other packages loaded by Astro from npm.  Vite
+resolves these imports through *node\_modules/* rather than Deno's JSR import
+map.
+
 If you are using Deno, you should import `@deno/astro-adapter` in
 *astro.config.mjs* and use it as the adapter:
 

packages/astro/compat/run.ts

@@ -57,11 +57,12 @@ async function testCompatibility(testCase: CompatibilityCase): Promise<void> {
     `Astro ${testCase.astro}, ${adapterName} ${testCase.adapter}, ${testCase.runtime}`;
   console.log(`Testing ${label}...`);
   const tempDir = await Deno.makeTempDir({ prefix: "fedify-astro-compat-" });
+  const port = reservePort();
   try {
     const tarballs = await packFedifyPackages(tempDir);
     await Deno.writeTextFile(
       join(tempDir, "astro.config.mjs"),
-      await getAstroConfig(testCase),
+      await getAstroConfig(testCase, port),
     );
     await copy(join(compatDir, "src"), join(tempDir, "src"));
     await Deno.writeTextFile(
@@ -89,7 +90,7 @@ async function testCompatibility(testCase: CompatibilityCase): Promise<void> {
 
     await run(["pnpm", "install", "--strict-peer-dependencies"], tempDir);
     await run(["pnpm", "exec", "astro", "build"], tempDir);
-    await exerciseServer(tempDir, testCase.runtime);
+    await exerciseServer(tempDir, testCase.runtime, port);
     console.log(`Passed ${label}.`);
   } finally {
     if (Deno.env.get("KEEP_ASTRO_COMPAT") == null) {
@@ -100,7 +101,10 @@ async function testCompatibility(testCase: CompatibilityCase): Promise<void> {
   }
 }
 
-async function getAstroConfig(testCase: CompatibilityCase): Promise<string> {
+async function getAstroConfig(
+  testCase: CompatibilityCase,
+  port: number,
+): Promise<string> {
   if (!testCase.astro.startsWith("^7.")) {
     return await Deno.readTextFile(join(compatDir, "astro.config.mjs.tpl"));
   }
@@ -122,6 +126,16 @@ async function getAstroConfig(testCase: CompatibilityCase): Promise<string> {
   });
   const config = initializer.files?.["astro.config.ts"];
   if (config == null) throw new Error("Astro initializer produced no config");
+  if (testCase.runtime === "deno") {
+    const configured = config.replace(
+      "adapter: deno(),",
+      `adapter: deno({ port: ${port} }),`,
+    );
+    if (configured === config) {
+      throw new Error("Could not configure the Deno compatibility test port");
+    }
+    return configured;
+  }
   return config;
 }
 
@@ -167,8 +181,8 @@ async function packFedifyPackages(
 async function exerciseServer(
   dir: string,
   runtime: "node" | "deno" | "bun",
+  port: number,
 ): Promise<void> {
-  const port = runtime === "deno" ? 8085 : reservePort();
   const command = new Deno.Command(runtime, {
     args: runtime === "deno"
       ? ["run", "-A", "dist/server/entry.mjs"]

packages/init/src/action/configs.ts

@@ -124,7 +124,7 @@ const getLinks = <
   T extends Pick<InitCommandData, "kv" | "mq" | "initializer" | "dir">,
 >({ kv, mq, initializer, dir }: T) =>
   pipe(
-    { "@fedify/fedify": "" },
+    { "@fedify/fedify": "", "@fedify/vocab": "" },
     merge(initializer.dependencies),
     merge(kv.dependencies),
     merge(mq.dependencies),

packages/init/src/action/utils.ts

@@ -1,4 +1,5 @@
 import $ from "@david/dax";
+import { readFile, writeFile } from "node:fs/promises";
 import { join as joinPath } from "node:path";
 import type { InitCommandData } from "../types.ts";
 
@@ -88,8 +89,24 @@ export function stringifyEnvs(object: Record<string, string>): string {
  * Runs `<packageManager> install` in the project directory to install all
  * dependencies. Logs an error message if the installation fails.
  */
-export const installDependencies = ({ packageManager, dir }: InitCommandData) =>
-  $`${packageManager} install`.cwd(dir).spawn();
+export const installDependencies = async (data: InitCommandData) => {
+  const { packageManager, dir, testMode } = data;
+  if (packageManager !== "deno" || !testMode) {
+    return await $`${packageManager} install`.cwd(dir).spawn();
+  }
+
+  const configPath = joinPath(dir, "deno.json");
+  const config = JSON.parse(await readFile(configPath, "utf8"));
+  const links = config.links;
+  delete config.links;
+  await writeFile(configPath, JSON.stringify(config, null, 2) + "\n");
+  try {
+    return await $`${packageManager} install`.cwd(dir).spawn();
+  } finally {
+    config.links = links;
+    await writeFile(configPath, JSON.stringify(config, null, 2) + "\n");
+  }
+};
 
 /**
  * Runs the precommand specified in the initializer to set up the project.

packages/init/src/package.test.ts

@@ -3,6 +3,7 @@ import { access, readFile } from "node:fs/promises";
 import { dirname, resolve } from "node:path";
 import test from "node:test";
 import { fileURLToPath } from "node:url";
+import { PACKAGE_VERSION } from "./lib.ts";
 import astroDescription from "./webframeworks/astro.ts";
 
 const packageDir = resolve(dirname(fileURLToPath(import.meta.url)), "..");
@@ -60,6 +61,10 @@ test("Astro init pins the Astro 7 scaffolder and dependencies", async () => {
       packageManager === "deno" ? "npm:astro@^7.0.7" : "^7.0.7",
     );
     if (packageManager === "deno") {
+      strictEqual(
+        result.dependencies?.["@fedify/astro"],
+        `npm:@fedify/astro@${PACKAGE_VERSION}`,
+      );
       strictEqual(
         result.dependencies?.["@deno/astro-adapter"],
         "npm:@deno/astro-adapter@^0.6.0",

packages/init/src/test/create.ts

@@ -1,8 +1,8 @@
 import $ from "@david/dax";
 import { filter, isEmpty, pipe, toArray } from "@fxts/core";
 import { values } from "@optique/core";
-import { appendFile, mkdir, stat } from "node:fs/promises";
-import { join, sep } from "node:path";
+import { appendFile, mkdir, readFile, stat, symlink } from "node:fs/promises";
+import { dirname, join, resolve, sep } from "node:path";
 import process from "node:process";
 import packageManagers from "../json/pm.json" with { type: "json" };
 import { getBuildCommand, kvStores, messageQueues } from "../lib.ts";
@@ -180,7 +180,8 @@ async function validateFrameworkBuild(
     KvStore,
     MessageQueue,
   ];
-  if (webFramework !== "astro" || packageManager === "deno") return true;
+  if (webFramework !== "astro") return true;
+  if (packageManager === "deno") await linkDenoWorkspacePackages(dir);
   const result = await $`${getBuildCommand(packageManager)}`
     .cwd(dir)
     .stdin("null")
@@ -192,6 +193,23 @@ async function validateFrameworkBuild(
   return result.code === 0;
 }
 
+async function linkDenoWorkspacePackages(dir: string): Promise<void> {
+  const config = JSON.parse(await readFile(join(dir, "deno.json"), "utf8"));
+  for (const link of config.links ?? []) {
+    const packageDir = resolve(dir, link);
+    const metadata = JSON.parse(
+      await readFile(join(packageDir, "package.json"), "utf8"),
+    );
+    const target = join(dir, "node_modules", ...metadata.name.split("/"));
+    await mkdir(dirname(target), { recursive: true });
+    try {
+      await stat(target);
+    } catch {
+      await symlink(packageDir, target, "junction");
+    }
+  }
+}
+
 export function filterOptions(
   options: GeneratedType<ReturnType<typeof generateTestCases>>,
 ): boolean {

packages/init/src/webframeworks/astro.ts

@@ -26,11 +26,14 @@ const astroDescription: WebFrameworkDescription = {
     const dependencies: Record<string, string> = pm === "deno"
       ? {
         ...defaultDenoDependencies,
+        "@fedify/fedify": `npm:@fedify/fedify@${PACKAGE_VERSION}`,
+        "@fedify/vocab": `npm:@fedify/vocab@${PACKAGE_VERSION}`,
+        "@logtape/logtape": `npm:@logtape/logtape@${deps["@logtape/logtape"]}`,
         astro: `npm:astro@${deps["npm:astro"]}`,
         "@deno/astro-adapter": `npm:@deno/astro-adapter@${
           deps["npm:@deno/astro-adapter"]
         }`,
-        "@fedify/astro": PACKAGE_VERSION,
+        "@fedify/astro": `npm:@fedify/astro@${PACKAGE_VERSION}`,
       }
       : pm === "bun"
       ? {