Skip to content

Commit 1af05cc

Browse files
author
Paul Whalen
committed
ci: remove continue-on-error from workflow jobs
continue-on-error: true at the job level has no practical effect and no downstream jobs depend on these tests. Assisted-by: Claude (claude-opus-4-6) Signed-off-by: Paul Whalen <pwhalen@fedoraproject.org>
1 parent 6e59e73 commit 1af05cc

2 files changed

Lines changed: 0 additions & 16 deletions

File tree

.github/workflows/comment-ci.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ jobs:
6565
centos-10-bootc:
6666
needs: check-pull-request
6767
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
68-
continue-on-error: true
6968
runs-on: ubuntu-latest
7069
permissions:
7170
statuses: write
@@ -89,7 +88,6 @@ jobs:
8988
fedora-44-bootc:
9089
needs: check-pull-request
9190
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
92-
continue-on-error: true
9391
runs-on: ubuntu-latest
9492
permissions:
9593
statuses: write
@@ -113,7 +111,6 @@ jobs:
113111
fedora-45-bootc:
114112
needs: check-pull-request
115113
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
116-
continue-on-error: true
117114
runs-on: ubuntu-latest
118115
permissions:
119116
statuses: write
@@ -137,7 +134,6 @@ jobs:
137134
fedora-44-ostree:
138135
needs: check-pull-request
139136
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
140-
continue-on-error: true
141137
runs-on: ubuntu-latest
142138
permissions:
143139
statuses: write
@@ -161,7 +157,6 @@ jobs:
161157
fedora-45-ostree:
162158
needs: check-pull-request
163159
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
164-
continue-on-error: true
165160
runs-on: ubuntu-latest
166161
permissions:
167162
statuses: write
@@ -185,7 +180,6 @@ jobs:
185180
centos-9-ostree:
186181
needs: check-pull-request
187182
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
188-
continue-on-error: true
189183
runs-on: ubuntu-latest
190184
permissions:
191185
statuses: write
@@ -209,7 +203,6 @@ jobs:
209203
rhel-9-8-ostree:
210204
needs: check-pull-request
211205
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
212-
continue-on-error: true
213206
runs-on: ubuntu-latest
214207
permissions:
215208
statuses: write
@@ -233,7 +226,6 @@ jobs:
233226
rhel-10-2-bootc:
234227
needs: check-pull-request
235228
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
236-
continue-on-error: true
237229
runs-on: ubuntu-latest
238230
permissions:
239231
statuses: write

.github/workflows/greenboot-ci.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ jobs:
6565
centos-10-bootc:
6666
needs: check-pull-request
6767
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
68-
continue-on-error: true
6968
runs-on: ubuntu-latest
7069
permissions:
7170
statuses: write
@@ -89,7 +88,6 @@ jobs:
8988
fedora-44-bootc:
9089
needs: check-pull-request
9190
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
92-
continue-on-error: true
9391
runs-on: ubuntu-latest
9492
permissions:
9593
statuses: write
@@ -113,7 +111,6 @@ jobs:
113111
fedora-45-bootc:
114112
needs: check-pull-request
115113
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
116-
continue-on-error: true
117114
runs-on: ubuntu-latest
118115
permissions:
119116
statuses: write
@@ -137,7 +134,6 @@ jobs:
137134
fedora-44-ostree:
138135
needs: check-pull-request
139136
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
140-
continue-on-error: true
141137
runs-on: ubuntu-latest
142138
permissions:
143139
statuses: write
@@ -161,7 +157,6 @@ jobs:
161157
fedora-45-ostree:
162158
needs: check-pull-request
163159
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
164-
continue-on-error: true
165160
runs-on: ubuntu-latest
166161
permissions:
167162
statuses: write
@@ -185,7 +180,6 @@ jobs:
185180
centos-9-ostree:
186181
needs: check-pull-request
187182
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
188-
continue-on-error: true
189183
runs-on: ubuntu-latest
190184
permissions:
191185
statuses: write
@@ -209,7 +203,6 @@ jobs:
209203
rhel-9-8-ostree:
210204
needs: check-pull-request
211205
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
212-
continue-on-error: true
213206
runs-on: ubuntu-latest
214207
permissions:
215208
statuses: write
@@ -233,7 +226,6 @@ jobs:
233226
rhel-10-2-bootc:
234227
needs: check-pull-request
235228
if: ${{ needs.check-pull-request.outputs.allowed_user == 'true' }}
236-
continue-on-error: true
237229
runs-on: ubuntu-latest
238230
permissions:
239231
statuses: write

0 commit comments

Comments
 (0)