Skip to content

Commit 7f563fa

Browse files
committed
ci: install systemd-rpm-macros in make-rpm job
greenboot-rs.spec has an unconditional BuildRequires: systemd-rpm-macros, but the make-rpm job's dnf install step never installs it, only git/make/rpm-build/rust-toolset. rpmbuild then fails dependency resolution before it ever gets to building anything: error: Failed build dependencies: systemd-rpm-macros is needed by greenboot-rs-0.16.3-0.el9.x86_64 Verified by running the exact dnf install + make rpm sequence against quay.io/centos/centos:stream9 (the job's own container image): with systemd-rpm-macros added, dnf resolves it straight from CentOS Stream 9 BaseOS/AppStream with no extra repo, and make rpm completes and produces all four expected RPMs. Assisted-by: OpenCode (Claude Sonnet 5)
1 parent 74f42a1 commit 7f563fa

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/comment-ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959

6060
- name: Build RPMs
6161
run: |
62-
dnf install -y git make rpm-build rust-toolset
62+
dnf install -y git make rpm-build rust-toolset systemd-rpm-macros
6363
make rpm
6464
6565
- name: Verify RPMs were created

.github/workflows/greenboot-ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959

6060
- name: Build RPMs
6161
run: |
62-
dnf install -y git make rpm-build rust-toolset
62+
dnf install -y git make rpm-build rust-toolset systemd-rpm-macros
6363
git config --global --add safe.directory /__w/greenboot-rs/greenboot-rs
6464
make rpm
6565

0 commit comments

Comments
 (0)