Merge pull request #56 from feedhenry/race-condition

wtrocki · web-flow · commit b1c7c8a81075 · 2019-12-19T11:43:36.000Z
Fix to cope with race condition with multiple refs for one sync record
diff --git a/lib/storage/dataset-clients.js b/lib/storage/dataset-clients.js
@@ -154,6 +154,8 @@ function upsertOrDeleteDatasetRecords(datasetId, datasetClientId, records, cb) {
     } else if (op === 'delete') {
       //remove the ref
       update['$pull'] = {'refs': datasetClientId};
+      // also set the hash to null to handle race condition when multiple refs associated with single record
+      update['$set']['hash'] = null;
     }
     datasetRecordsCol.findOneAndUpdate({uid: record.uid}, update, {upsert: true, returnOriginal: false}, function(err, updated) {
       if (err) {

Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,8 @@ function upsertOrDeleteDatasetRecords(datasetId, datasetClientId, records, cb) {`
`154`	`154`	`} else if (op === 'delete') {`
`155`	`155`	`//remove the ref`
`156`	`156`	`update['$pull'] = {'refs': datasetClientId};`
	`157`	`+ // also set the hash to null to handle race condition when multiple refs associated with single record`
	`158`	`+ update['$set']['hash'] = null;`
`157`	`159`	`}`
`158`	`160`	`datasetRecordsCol.findOneAndUpdate({uid: record.uid}, update, {upsert: true, returnOriginal: false}, function(err, updated) {`
`159`	`161`	`if (err) {`