Skip to content

Commit 1020b54

Browse files
runcomclaude
andcommitted
Fix delegate key generation to use DER format like other service keys
Change delegate EC key generation to use DER format (`-outform der`) to match the format used by all other service keys (owner, manufacturer, rendezvous, device_ca) in the test infrastructure. This ensures consistency across all key generation in tests and compatibility with go-fdo-server's private key parser. Modified: - test-delegate-onboarding.sh: Use `-outform der` and `-keyform der` Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent dedb665 commit 1020b54

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

test/ci/test-delegate-onboarding.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ generate_delegate_cert() {
3131
local delegate_cnf_path="${delegate_key_path%.key}.cnf"
3232
local delegate_csr_path="${delegate_key_path%.key}.csr"
3333

34-
log_info "Generating delegate EC key"
35-
openssl ecparam -name prime256v1 -genkey -out "${delegate_key_path}" 2>/dev/null
34+
log_info "Generating delegate EC key in DER format (same as other service keys)"
35+
openssl ecparam -name prime256v1 -genkey -outform der -out "${delegate_key_path}" 2>/dev/null
3636

3737
log_info "Creating delegate openssl config with FDO permission OID ${permissions_oid}"
3838
cat >"${delegate_cnf_path}" <<EOF
@@ -43,7 +43,7 @@ extendedKeyUsage = ${permissions_oid}
4343
EOF
4444

4545
log_info "Generating delegate CSR"
46-
openssl req -new -key "${delegate_key_path}" -out "${delegate_csr_path}" -subj "/CN=FDO Delegate" 2>/dev/null
46+
openssl req -new -key "${delegate_key_path}" -keyform der -out "${delegate_csr_path}" -subj "/CN=FDO Delegate" 2>/dev/null
4747

4848
log_info "Signing delegate cert with owner key"
4949
openssl x509 -req \

0 commit comments

Comments
 (0)