Skip to content

Commit ac96bff

Browse files
mcattamoredhatkgiusti
authored andcommitted
fix(test): install RPMs before generating service certificates
run_test() (test/ci/test-onboarding.sh) generated service certificates before installing go-fdo-client/go-fdo-server. That ordering never mattered for the default generate_service_certs(), which just runs openssl locally with no dependency on either package being installed. test/rpm/test-onboarding-defaults.sh overrides generate_service_certs() to instead call the go-fdo-server RPM's own /usr/libexec/go-fdo-server/generate-go-fdo-server-certs.sh, which only exists after install_server() has installed the package. Because run_test() called it first, the override always failed with "command not found", and every step downstream failed in turn. Swap the two steps: install_client/install_server now run before generate_service_certs. Safe for every existing caller of this shared run_test(), since neither direction of dependency exists for the default cert generation. Assisted-by: Claude (claude-sonnet-5) Signed-off-by: Mario Cattamo <mcattamo@redhat.com>
1 parent a60e5f6 commit ac96bff

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

test/ci/test-onboarding.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,15 @@ run_test() {
1616
log_info "Creating directories"
1717
create_directories
1818

19-
log_info "Generating service certificates"
20-
generate_service_certs
21-
2219
log_info "Build and install 'go-fdo-client' binary"
2320
install_client
2421

2522
log_info "Build and install 'go-fdo-server' binary"
2623
install_server
2724

25+
log_info "Generating service certificates"
26+
generate_service_certs
27+
2828
log_info "Configuring services"
2929
configure_services
3030

0 commit comments

Comments
 (0)