Commit ac96bff
fix(test): install RPMs before generating service certificates
run_test() (test/ci/test-onboarding.sh) generated service certificates
before installing go-fdo-client/go-fdo-server. That ordering never
mattered for the default generate_service_certs(), which just runs
openssl locally with no dependency on either package being installed.
test/rpm/test-onboarding-defaults.sh overrides generate_service_certs()
to instead call the go-fdo-server RPM's own
/usr/libexec/go-fdo-server/generate-go-fdo-server-certs.sh, which only
exists after install_server() has installed the package. Because
run_test() called it first, the override always failed with
"command not found", and every step downstream failed in turn.
Swap the two steps: install_client/install_server now run before
generate_service_certs. Safe for every existing caller of this shared
run_test(), since neither direction of dependency exists for the
default cert generation.
Assisted-by: Claude (claude-sonnet-5)
Signed-off-by: Mario Cattamo <mcattamo@redhat.com>1 parent a60e5f6 commit ac96bff
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | 19 | | |
23 | 20 | | |
24 | 21 | | |
25 | 22 | | |
26 | 23 | | |
27 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
0 commit comments