Query is generated twice when using getNavigationBadge()

[kombiahrk]

When using getNavigationBadge() count query is generating two times for each resource where getNavigationBadge() method is used.

<?php

namespace App\Filament\App\Resources;

use App\Filament\App\Resources\TaskResource\Pages;
use App\Filament\App\Resources\TaskResource\RelationManagers;
use App\Models\Task;
use Filament\Forms;
use Filament\Forms\Form;
use Filament\Resources\Resource;
use Filament\Tables;
use Filament\Tables\Table;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\SoftDeletingScope;

class TaskResource extends Resource
{
    protected static ?string $model = Task::class;

    protected static ?string $navigationIcon = 'heroicon-o-rectangle-stack';

    public static function getNavigationBadge(): ?string
    {
        return static::getModel()::where('completed','0')->count();
    }

    public static function form(Form $form): Form
    {
        return $form
            ->schema([
                Forms\Components\Section::make()->schema([
                    Forms\Components\TextInput::make('title')
                        ->required()
                        ->maxLength(255),
                    Forms\Components\Select::make('priority')
                        ->options([
                            'low' => 'Low',
                            'medium' => 'Medium',
                            'high' => 'High',
                        ])
                        ->required(),
                    Forms\Components\DatePicker::make('due_date')
                        ->required(),
                ])->columns(3),
                Forms\Components\Textarea::make('description')
                    ->maxLength(65535)
                    ->columnSpanFull(),
            ])->columns(1);
    }

    public static function table(Table $table): Table
    {
        return $table
            ->columns([
                Tables\Columns\TextColumn::make('title')
                    ->searchable(),
                Tables\Columns\TextColumn::make('priority')
                    ->badge()
                    ->formatStateUsing(fn (string $state): string => match ($state){
                        'low' => 'Low',
                        'medium' => 'Medium',
                        'high' => 'High',
                })
                    ->color(fn (string $state): string => match ($state){
                        'low' => 'gray',
                        'medium' => 'warning',
                        'high' => 'danger',
                }),
                Tables\Columns\TextColumn::make('due_date')
                    ->date()
                    ->sortable(),
                Tables\Columns\ToggleColumn::make('completed')
                    ->onColor('success')
                    ->offColor('danger')
                    ->beforeStateUpdated(function ($record, $state) {
                        // Runs after the state is saved to the database.
                        //dd($record);
                        $record->completed_at = today();
                    }),
                Tables\Columns\TextColumn::make('completed_at')
                    ->date()
                    ->sortable()
                    ->toggleable(isToggledHiddenByDefault: true),
                Tables\Columns\TextColumn::make('created_at')
                    ->dateTime()
                    ->sortable()
                    ->toggleable(isToggledHiddenByDefault: true),
                Tables\Columns\TextColumn::make('updated_at')
                    ->dateTime()
                    ->sortable()
                    ->toggleable(isToggledHiddenByDefault: true),
                Tables\Columns\TextColumn::make('deleted_at')
                    ->dateTime()
                    ->sortable()
                    ->toggleable(isToggledHiddenByDefault: true),
            ])
            ->modifyQueryUsing(function ($query) {
                //$query->where('completed', 0)->orderby('priority', 'desc')->orderby('due_date');
                $query->orderby('completed')->orderby('priority', 'desc')->orderby('due_date');
            })
            ->filters([
                //
            ])
            ->actions([
                Tables\Actions\EditAction::make(),
            ])
            ->bulkActions([
                Tables\Actions\BulkActionGroup::make([
                    Tables\Actions\DeleteBulkAction::make(),
                ]),
            ]);
    }

    public static function getRelations(): array
    {
        return [
            //
        ];
    }

    public static function getPages(): array
    {
        return [
            'index' => Pages\ListTasks::route('/'),
            'create' => Pages\CreateTask::route('/create'),
            'edit' => Pages\EditTask::route('/{record}/edit'),
        ];
    }
}

[PetroZaburko]

Hi! Did you have a solution? Because I have the same problem

[sybex]

Same here.

[omarabdelaz1z]

I have same issue also

[000yuying]

I have the same issue,
and when I have a large number of records, it greatly affects the performance of the database.

[Rattone]

same here

[Rattone]

Can you please open an issue for this?

[sdiama]

An issue opened at #13388

[getupkid]

A work around for this could be to set the count in a property and then only run the query if the property is not set:
A bit hacky...but does the job.
e.g.

protected static ?string $navigationBadge = '';

//...
public static function getNavigationBadge(): ?string
    {
        if(!self::$navigationBadge) {
            self::$navigationBadge = static::getModel()::where('completed','0')->count();
        }
        return self::$navigationBadge;
    }
//...