MDE behaves differently when submitted via mouse click vs keyBinding

[bilogic]

Package

filament/forms

Package Version

3.2.80

Laravel Version

11.7.0

Livewire Version

3.4.12

PHP Version

8.2.18

Problem description

The behavior of clicking on submit vs pressing the registered keyBinding() is different.
Clicking will clear the form. (correct)
Pressing the shortcut key does not. (incorrect)

Expected behavior

Pressing the shortcut key should also clear the form.

Steps to reproduce

1. Type something into the markdown editor at /admin/issue
2. Press ctrl + enter

Reproduction repository

https://github.com/bilogic/filament-issue/tree/click-different-from-keyBindings

Relevant log output

vid.mp4

No response

[alexmanase]

It's because of this line:

filament/packages/forms/resources/js/components/markdown-editor.js

Line 208 in 9824951

if (this.editor.codemirror.hasFocus()) {

When the editor is focused, the state is not changed.

@danharrin if you think this is a bug, I can create a PR.

[danharrin]

Its deliberate, to prevent an infinite loop of state updates when the editor is being typed into

[bilogic]

Well, what I can say is, from a user POV, it looks like a bug.
Perhaps ctrl + enter can be made to steal the focus first before submitting?

@alexmanase will your PR overcome the infinite loop?

[alexmanase]

I guess. Still looking into it.

[alexmanase]

Perhaps ctrl + enter can be made to steal the focus first before submitting?

Thank you @bilogic. After checking other solutions, this one seemed to be the best. Let's see if ok for merging.

[bilogic]

Thanks for the fix!