Skip to content

Commit e4ea9a1

Browse files
committed
Correct order for YB. DDL then DML
1 parent 3f3d6da commit e4ea9a1

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

harmony/harmonydb/sql/20260521-pdp-v0-pull-refactor.sql

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@ ALTER TABLE pdp_piece_pull_items
1313
ALTER TABLE pdp_piece_pull_items
1414
ADD COLUMN IF NOT EXISTS created_at TIMESTAMPTZ NOT NULL DEFAULT NOW();
1515

16-
UPDATE pdp_piece_pull_items fi
17-
SET created_at = COALESCE(pp.created_at, fi.created_at)
18-
FROM pdp_piece_pulls pp
19-
WHERE pp.id = fi.fetch_id;
20-
2116
ALTER TABLE pdp_piece_pull_items
2217
ADD COLUMN IF NOT EXISTS parked_piece_ref BIGINT REFERENCES parked_piece_refs(ref_id) ON DELETE SET NULL;
2318

@@ -30,18 +25,23 @@ ALTER TABLE pdp_piece_pull_items
3025
ALTER TABLE pdp_piece_pull_items
3126
ADD CONSTRAINT pdp_piece_pull_items_pkey PRIMARY KEY (fetch_id, piece_cid, source_url);
3227

33-
UPDATE pdp_piece_pull_items fi
34-
SET task_id = NULL
35-
WHERE fi.task_id IS NOT NULL
36-
AND NOT EXISTS (
37-
SELECT 1
38-
FROM harmony_task ht
39-
WHERE ht.id = fi.task_id
40-
);
41-
4228
ALTER TABLE pdp_piece_pull_items
4329
DROP CONSTRAINT IF EXISTS pdp_piece_pull_items_terminal_state_check;
4430

4531
ALTER TABLE pdp_piece_pull_items
4632
ADD CONSTRAINT pdp_piece_pull_items_terminal_state_check
4733
CHECK (NOT (complete AND failed));
34+
35+
UPDATE pdp_piece_pull_items fi
36+
SET created_at = COALESCE(pp.created_at, fi.created_at)
37+
FROM pdp_piece_pulls pp
38+
WHERE pp.id = fi.fetch_id;
39+
40+
UPDATE pdp_piece_pull_items fi
41+
SET task_id = NULL
42+
WHERE fi.task_id IS NOT NULL
43+
AND NOT EXISTS (
44+
SELECT 1
45+
FROM harmony_task ht
46+
WHERE ht.id = fi.task_id
47+
);

0 commit comments

Comments
 (0)