Today @LexLuthr and I discussed a minor annoyance related to merging pdpv0-user-termination branch to main after #1246 and #1253 land. fwss service is adding a new termination signature which allows passing extradata for client auth. We should call the generated data accessor FilecoinWarmStorageServiceCaller.VERSION to determine if the contract has upgraded yet and if not fail the user generated termination flow. The non-user generated non-extradata call is left backwards compatible on the contract so we don't need to touch the provider triggered termination flow.
The other alterative is not merging pdpv0-user-termination to main until the fwss contract updates.
Yet another alternative is merging everything but always failing the user termination as a rule in code and only undoing that in a PR once we know the contract is upgraded.
Today @LexLuthr and I discussed a minor annoyance related to merging
pdpv0-user-terminationbranch tomainafter #1246 and #1253 land. fwss service is adding a new termination signature which allows passing extradata for client auth. We should call the generated data accessorFilecoinWarmStorageServiceCaller.VERSIONto determine if the contract has upgraded yet and if not fail the user generated termination flow. The non-user generated non-extradata call is left backwards compatible on the contract so we don't need to touch the provider triggered termination flow.The other alterative is not merging
pdpv0-user-terminationto main until the fwss contract updates.Yet another alternative is merging everything but always failing the user termination as a rule in code and only undoing that in a PR once we know the contract is upgraded.