fix: Windows compatibility — portable test-pack paths, tolerant assertions (#355)

* fix: make test-pack writing and transform assertions Windows-compatible

- PipelineTestPackWriter: store sample input/output paths in the
  test-pack model with '/' separators via UrlUtils.toPortableString;
  Path.toString() wrote backslashes on Windows into JSON that is later
  resolved as classpath resources
- TransformTestExtension: normalise line endings before comparing the
  expected output file with the freshly serialised output, matching the
  existing assertJsonEquals convention
- LatestSchemesImportTest: zip entry names always use '/' per the ZIP
  spec, so do not test them against File.separator
- Add .gitattributes pinning LF so expectation files survive
  core.autocrlf on Windows

Relies on rune-common pinning '\n' in its pretty printers, so writers in
this library now produce identical output on every platform.

* chore: update Rune DSL to 10.2.3

10.2.3 includes the Windows-compatibility fixes from finos/rune-dsl#1324.

* ci: add PR checks on Ubuntu and Windows

Mirrors the check-pr workflow in finos/rune-dsl so Windows regressions
are caught at PR time. Long paths are enabled on Windows before checkout.

Author: SimonCockx

.github/workflows/check-pr.yml

@@ -0,0 +1,38 @@
+name: PR Checks
+
+on:
+  pull_request:
+
+# Cancel previous jobs
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  build-on-ubuntu:
+    name: Maven Build on Ubuntu
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v6
+    - uses: actions/setup-java@v5
+      with:
+        java-version: '21'
+        distribution: temurin
+        cache: maven
+    - name: Build with Maven
+      run: mvn -B clean package
+
+  build-on-windows:
+    name: Maven Build on Windows
+    runs-on: windows-latest
+    steps:
+    - name: Enable git long paths
+      run: git config --system core.longpaths true
+    - uses: actions/checkout@v6
+    - uses: actions/setup-java@v5
+      with:
+        java-version: '21'
+        distribution: temurin
+        cache: maven
+    - name: Build with Maven
+      run: mvn -B clean package

pom.xml

@@ -92,7 +92,7 @@
         <java.enforced.version>[21,22)</java.enforced.version>
         <maven.compiler.release>21</maven.compiler.release>
 
-        <rune.dsl.version>10.2.2</rune.dsl.version>
+        <rune.dsl.version>10.2.3</rune.dsl.version>
         <rune.common.version>0.0.0.main-SNAPSHOT</rune.common.version>
 
         <xtext.version>2.38.0</xtext.version>

src/main/java/com/regnosys/testing/pipeline/PipelineTestPackWriter.java

@@ -60,6 +60,7 @@
 import java.util.stream.Stream;
 
 import static com.regnosys.rosetta.common.util.UrlUtils.getBaseFileName;
+import static com.regnosys.rosetta.common.util.UrlUtils.toPortableString;
 
 public class PipelineTestPackWriter {
 
@@ -207,7 +208,9 @@ private TestPackModel writeTestPackSamples(Path resourcesPath,
             String baseFileName = getBaseFileName(inputSample.toUri().toURL());
             String displayName = baseFileName.replace("-", " ");
 
-            TestPackModel.SampleModel sampleModel = new TestPackModel.SampleModel(baseFileName.toLowerCase(), displayName, inputSample.toString(), outputPath.toString(), assertions);
+            // Sample paths are stored in the test-pack model and resolved as classpath
+            // resources, so they always use "/" regardless of the platform separator
+            TestPackModel.SampleModel sampleModel = new TestPackModel.SampleModel(baseFileName.toLowerCase(), displayName, toPortableString(inputSample), toPortableString(outputPath), assertions);
             sampleModels.add(sampleModel);
 
             Files.createDirectories(resourcesPath.resolve(outputPath).getParent());

src/main/java/com/regnosys/testing/transform/TransformTestExtension.java

@@ -63,6 +63,7 @@
 import static com.regnosys.rosetta.common.transform.TestPackUtils.*;
 import static com.regnosys.rosetta.common.transform.TestPackUtils.getPipelineModel;
 import static com.regnosys.testing.TestingExpectationUtil.readStringFromResources;
+import static com.regnosys.testing.TestingExpectationUtil.normaliseLineEndings;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
@@ -197,7 +198,7 @@ private void runTransformAndAssert(String testPackId, TestPackModel.SampleModel
         }
 
         String expectedOutput = readStringFromResources(Path.of(sampleModel.getOutputPath()));
-        assertEquals(expectedOutput, actualOutput);
+        assertEquals(normaliseLineEndings(expectedOutput), normaliseLineEndings(actualOutput));
 
         TestPackModel.SampleModel.Assertions expectedAssertions = sampleModel.getAssertions();
         assertEquals(expectedAssertions, actualAssertions);

src/test/java/com/regnosys/testing/schemeimport/LatestSchemesImportTest.java

@@ -84,7 +84,8 @@ private static void unzip() {
 
                 boolean isDirectory = false;
                 //check for files or directory
-                if (zipEntry.getName().endsWith(File.separator)) {
+                // Zip entry names always use "/" regardless of the platform separator
+                if (zipEntry.getName().endsWith("/")) {
                     isDirectory = true;
                 }