Skip to content

Commit 4d7b29e

Browse files
authored
Merge pull request #811 from keikeicheung/main
add logs around vuu sorting issue
2 parents afa882b + e509255 commit 4d7b29e

2 files changed

Lines changed: 60 additions & 28 deletions

File tree

vuu/src/main/scala/org/finos/vuu/viewport/ViewPortCallable.scala

Lines changed: 23 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,40 @@
11
package org.finos.vuu.viewport
22

3+
import com.typesafe.scalalogging.StrictLogging
4+
35
import java.util.concurrent.{Callable, FutureTask}
46

5-
object ViewPortCallable {
7+
trait ViewPortCallableMBean {
8+
def apply(r: FutureTask[ViewPort], viewPortContainer: ViewPortContainer): Callable[ViewPort]
9+
}
10+
object ViewPortCallable extends StrictLogging with ViewPortCallableMBean {
611

712
def apply(r: FutureTask[ViewPort], viewPortContainer: ViewPortContainer): Callable[ViewPort] = {
813
() => {
9-
val viewport = r.get()
10-
viewPortContainer.refreshOneViewPort(viewport)
11-
viewport
14+
try {
15+
val viewport = r.get()
16+
viewPortContainer.refreshOneViewPort(viewport)
17+
viewport
18+
} catch {
19+
case e: Exception => logger.error(e.getMessage + " - " + e.getStackTrace)
20+
null
21+
}
1222
}
1323
}
1424
}
1525

16-
object ViewPortTreeCallable {
26+
object ViewPortTreeCallable extends StrictLogging with ViewPortCallableMBean {
1727

1828
def apply(r: FutureTask[ViewPort], viewPortContainer: ViewPortContainer): Callable[ViewPort] = {
1929
() => {
20-
val viewport = r.get()
21-
viewPortContainer.refreshOneTreeViewPort(viewport)
22-
viewport
30+
try {
31+
val viewport = r.get()
32+
viewPortContainer.refreshOneTreeViewPort(viewport)
33+
viewport
34+
} catch {
35+
case e: Exception => logger.error(e.getMessage + " - " + e.getStackTrace)
36+
null
37+
}
2338
}
2439
}
2540
}

vuu/src/main/scala/org/finos/vuu/viewport/ViewPortWorkItem.scala

Lines changed: 37 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,52 @@
11
package org.finos.vuu.viewport
22

3+
import com.typesafe.scalalogging.StrictLogging
34
import org.finos.toolbox.thread.WorkItem
45

5-
object ViewPortWorkItem{
6+
object ViewPortWorkItem extends StrictLogging {
67
def apply(viewPort: ViewPort, container: ViewPortContainer): WorkItem[ViewPort] = {
7-
new WorkItem[ViewPort] {
8-
override def doWork(): ViewPort = {
9-
container.refreshOneViewPort(viewPort)
10-
viewPort
11-
}
12-
override def toString: String = "Runner:[" + viewPort + "]"
13-
override def hashCode(): Int = viewPort.hashCode()
14-
override def equals(obj: Any): Boolean = {
15-
this.hashCode() == obj.hashCode()
8+
try {
9+
new WorkItem[ViewPort] {
10+
override def doWork(): ViewPort = {
11+
container.refreshOneViewPort(viewPort)
12+
viewPort
13+
}
14+
15+
override def toString: String = "Runner:[" + viewPort + "]"
16+
17+
override def hashCode(): Int = viewPort.hashCode()
18+
19+
override def equals(obj: Any): Boolean = {
20+
this.hashCode() == obj.hashCode()
21+
}
1622
}
23+
} catch {
24+
case e: Exception => logger.error(e.getMessage + " " + e.getStackTrace)
25+
null
1726
}
1827
}
1928
}
2029

21-
object ViewPortTreeWorkItem{
30+
object ViewPortTreeWorkItem extends StrictLogging {
2231
def apply(viewPort: ViewPort, container: ViewPortContainer): WorkItem[ViewPort] = {
23-
new WorkItem[ViewPort] {
24-
override def doWork(): ViewPort = {
25-
container.refreshOneTreeViewPort(viewPort)
26-
viewPort
27-
}
28-
override def toString: String = "TreeRunner:[" + viewPort + "]"
29-
override def hashCode(): Int = viewPort.hashCode()
30-
override def equals(obj: Any): Boolean = {
31-
this.hashCode() == obj.hashCode()
32+
try {
33+
new WorkItem[ViewPort] {
34+
override def doWork(): ViewPort = {
35+
container.refreshOneTreeViewPort(viewPort)
36+
viewPort
37+
}
38+
39+
override def toString: String = "TreeRunner:[" + viewPort + "]"
40+
41+
override def hashCode(): Int = viewPort.hashCode()
42+
43+
override def equals(obj: Any): Boolean = {
44+
this.hashCode() == obj.hashCode()
45+
}
3246
}
47+
} catch {
48+
case e: Exception => logger.error(e.getMessage + " " + e.getStackTrace)
49+
null
3350
}
3451
}
3552
}

0 commit comments

Comments
 (0)