Skip to content

Commit 67afde4

Browse files
authored
config update should trigget batch mode (#797)
1 parent 48ea346 commit 67afde4

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

vuu-ui/packages/vuu-data/src/remote-data-source.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,6 @@ export class RemoteDataSource
500500
}
501501

502502
set groupBy(groupBy: VuuGroupBy) {
503-
console.log(`set GROUPBY ${groupBy.join()}`);
504503
if (itemsOrOrderChanged(this.groupBy, groupBy)) {
505504
const wasGrouped = this.#groupBy.length > 0;
506505
this.#config = {
@@ -528,8 +527,6 @@ export class RemoteDataSource
528527
}
529528
this.emit("config", this.#config);
530529
this.setConfigPending({ groupBy });
531-
} else {
532-
console.log(`RemoteDataSource groupBy set, but value not changed`);
533530
}
534531
}
535532

vuu-ui/packages/vuu-data/src/server-proxy/viewport.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -639,6 +639,10 @@ export class Viewport {
639639

640640
const { filter, ...remainingConfig } = config;
641641

642+
if (this.useBatchMode) {
643+
this.batchMode = true;
644+
}
645+
642646
debugEnabled
643647
? debug?.(`setConfig ${JSON.stringify(config)}`)
644648
: info?.(`setConfig`);

0 commit comments

Comments
 (0)