Freeze and unfreeze view port - #1637
Merged
Merged
Conversation
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
tanjjj
marked this pull request as draft
July 29, 2025 16:09
tanjjj
force-pushed
the
support-freeze-viewport-at-backend
branch
from
August 4, 2025 13:09
b4d9d65 to
3a6cd15
Compare
stonesmi
reviewed
Aug 4, 2025
stonesmi
reviewed
Aug 4, 2025
tanjjj
marked this pull request as ready for review
August 5, 2025 17:58
tanjjj
force-pushed
the
support-freeze-viewport-at-backend
branch
from
August 5, 2025 18:25
7b06ab1 to
8b13538
Compare
stonesmi
requested changes
Aug 7, 2025
tanjjj
force-pushed
the
support-freeze-viewport-at-backend
branch
from
August 7, 2025 09:18
14fcccb to
12fe963
Compare
stonesmi
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default columns of creation time and last updated time are added to each table.
When a viewport is frozen, filter out the rows with creation time newer than freeze timestamp.
When a viewport is unfrozen, remove the filter.
If a viewport is already frozen, reject new freeze request.
And fixed an issue with RowPermissionFilter - user could remove any column from the viewport/vpColumns, hence we should give RowPermissionFilter the entire row of data
Note this PR doesn't cover freezing unfreezing view ports on a join table. Will do that in another PR for #1653.
closes #1646