No packets displayed: inspector is broken because of a platform change

[jsnajdr]

Since around 15-Dec-2016, the RDP inspector is broken - no packets are ever displayed in the UI and the addon logs an error about "window.postChromeMessage" being null.

Mozregression told me that the breaking change is bug 1322414. This changed the syntax for:

<browser type="content-primary">

to

<browser type="content" primary="true">

with no backward compatibility.

Fixing the <browser> elements in connections-window.xul and inspector-window.xul makes the RDP inspector work again.

A bad thing is that there is no way to specify content-primary in a way that works both before and after. But even if I remove the primary attribute, the inspector still works well, so maybe just <browser type="content"> is good enough in this case.

[bzbarsky]

A bad thing is that there is no way to specify content-primary in a way that works both before and after.

Does this not work?

<browser type="content-primary" primary="true">

I would expect it to work.

[bzbarsky]

Oh, I see. We stopped accepting "content-*" bits... Nevermind.