Skip to content

shallow_water_microphysics has factors in the wrong place #730

@12shughes

Description

@12shughes

Lines 307-332 of shallow_water_microphysics don't match the setup of Zerroukat & Allen 2015 (or Nell's thesis). Specifically lines 309-310 should compare gamma*sat_adj_expr to -self.cloud, and then not be multiplied by gamma afterwards. If sat_adj_expr on line 307 is multiplied by gamma this should fix the issue

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugPull requests or issues to relating to something not working correctly

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions