fix: on-complete index updates

Author: fiso64

README.md

@@ -522,20 +522,17 @@ When passing an on-complete action on the command line, quote the whole value so
 - `when=already-exists` - Execute only for already-existing skipped jobs
 - `when=not-found-last-time` - Execute only for not-found-last-time skipped jobs
 - `when=cancelled` - Execute only for cancelled jobs
-- `when=partial` - Execute only for partially successful container jobs
 - `when=completed` - Execute for all non-skipped terminal outcomes
 - `when=any` - Execute for every terminal outcome
 - `scope=track` - Execute only for track-level completions
 - `scope=album` - Execute only for album-level completions
 - `hidden` - Hide the command window
 - `shell` - Use shell execute
 - `lock` - Serialize this action across jobs
-- `update-index` - Use stdout to update the index and playlist path
+- `update-index` - Read stdout as `success;new_path`, `failed`, or `ignored;new_path` to update the track/album entry in the index and playlist. `failed` clears the stored path; `ignored;new_path` leaves the state unchanged and updates only the path.
 
 If `when=` is omitted, it behaves like `when=completed`. This preserves the usual "run when work completed" behavior while avoiding commands for already-existing or not-found-last-time skips.
 
-Sockseek captures bounded stdout/stderr for ordinary on-complete commands, so chained commands can use output variables without an extra option. Commands launched with `shell` use shell execute and cannot expose stdout/stderr. When using `update-index`, stdout should be `ignored;new_path` to update the track path in the index and playlist.
-
 ### Variables
 
 The available variables are the same as in [name-format](#available-variables), with the following additions:
@@ -546,6 +543,8 @@ The available variables are the same as in [name-format](#available-variables),
 - `{first-stdout}` - First command's stdout
 - `{first-stderr}` - First command's stderr
 
+Sockseek captures bounded stdout/stderr for ordinary on-complete commands, so chained commands can use output variables from the previous ones. Commands launched with `shell` use shell execute and cannot expose stdout/stderr.
+
 For album-only (`scope=album`) actions, tag variables such as `{title}`, `{artist}`, and `{album}` are read from the first audio file in the album. Job/source/path variables such as `{sartist}`, `{salbum}`, and `{path}` describe the album-level completion itself.
 
 ### Examples

Sockseek.Cli/Help.Content.cs

@@ -604,21 +604,18 @@ after it is the command passed to the operating system.
     - when=already-exists - Execute only for already-existing skipped jobs
     - when=not-found-last-time - Execute only for not-found-last-time skipped jobs
     - when=cancelled - Execute only for cancelled jobs
-    - when=partial - Execute only for partially successful container jobs
     - when=completed - Execute for all non-skipped terminal outcomes
     - when=any - Execute for every terminal outcome
     - scope=track - Execute only for track-level completions
     - scope=album - Execute only for album-level completions
     - hidden - Hide the command window
     - shell - Use shell execute
     - lock - Serialize this action across jobs
-    - update-index - Use stdout to update the index and playlist path
+    - update-index - Read stdout as success;new_path, failed, or ignored;new_path to update the
+      track/album entry in the index and playlist. failed clears the stored path; ignored;new_path
+      leaves the state unchanged and updates only the path.
     If when= is omitted, it behaves like when=completed. This preserves the usual ""run when work
     completed"" behavior while avoiding commands for already-existing or not-found-last-time skips.
-    Sockseek captures bounded stdout/stderr for ordinary on-complete commands, so chained commands
-    can use output variables without an extra option. Commands launched with shell use shell execute
-    and cannot expose stdout/stderr. When using update-index, stdout should be ignored;new_path to
-    update the track path in the index and playlist.
 
   Variables
     The available variables are the same as in name-format, with the following additions:
@@ -628,6 +625,9 @@ update the track path in the index and playlist.
     - {first-exitcode} - First command's exit code
     - {first-stdout} - First command's stdout
     - {first-stderr} - First command's stderr
+    Sockseek captures bounded stdout/stderr for ordinary on-complete commands, so chained commands
+    can use output variables from the previous ones. Commands launched with shell use shell execute
+    and cannot expose stdout/stderr.
     For album-only (scope=album) actions, tag variables such as {title}, {artist}, and {album} are
     read from the first audio file in the album. Job/source/path variables such as {sartist},
     {salbum}, and {path} describe the album-level completion itself.

Sockseek.Core.Tests/IndexTests.cs

@@ -112,6 +112,32 @@ public void Index_IndexRoundTrip_PreservesData()
             Assert.IsNull(prev3);
         }
 
+        [TestMethod]
+        public void Index_FailedJobWithClearedPath_UpdatesExistingPathToEmpty()
+        {
+            var song = new SongJob(new SongQuery { Artist = "Artist", Title = "Title" });
+            song.SetDone();
+            song.DownloadPath = "path/to/file.mp3";
+
+            var (queue, _, _) = MakeSongQueue([song]);
+            File.WriteAllText(testM3uPath, "");
+            var editor = new M3uEditor(testM3uPath, queue, M3uOption.Index, true);
+            editor.Update();
+
+            JobOutcomeCommitter.Commit(song, JobOutcome.Failed(JobFailureReason.AllDownloadsFailed, clearDownloadPath: true));
+            editor.Update();
+
+            var lookup = new SongJob(new SongQuery { Artist = "Artist", Title = "Title" });
+            var (queue2, _, _) = MakeSongQueue([lookup]);
+            var editor2 = new M3uEditor(testM3uPath, queue2, M3uOption.Index, true);
+
+            editor2.TryGetPreviousRunResult(lookup, out var prev);
+            Assert.IsNotNull(prev);
+            Assert.AreEqual(JobStateOld.Failed, prev.State);
+            Assert.AreEqual(JobFailureReason.AllDownloadsFailed, prev.FailureReason);
+            Assert.AreEqual("", prev.DownloadPath);
+        }
+
         [TestMethod]
         public void Index_SerializesFilePathsWithForwardSlashes()
         {
@@ -169,6 +195,7 @@ public void Index_WithAlbumJobs_RoundTripsCorrectly()
                 Assert.IsNotNull(prev, $"Previous run result not found for {lookupJobs[i].Query.Artist} - {lookupJobs[i].Query.Album}");
                 Assert.AreEqual(albumJobs[i].Query.Artist, prev.Artist);
                 Assert.AreEqual(albumJobs[i].Query.Album, prev.Album);
+                Assert.AreEqual(albumJobs[i].DownloadPath ?? "", prev.DownloadPath);
 
                 // Verify prev is a separate object from the job
                 string originalPath = albumJobs[i].DownloadPath ?? "";